-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](storage) For debugging problems: add session variable to treat agg and unique data model as dup model #11952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * For debugg purpose, dont' merge unique key and agg key when reading data. | ||
| */ | ||
| @VariableMgr.VarAttr(name = AGG_AS_DUPLICATE) | ||
| private boolean aggAsDuplicate = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the variable name: skip_storage_engine_merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| @VariableMgr.VarAttr(name = AGG_AS_DUPLICATE) | ||
| private boolean aggAsDuplicate = false; | ||
|
|
||
| public String getBlockEncryptionMode() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add another variable: skip_delete_predicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
be/src/vec/exec/volap_scanner.cpp
Outdated
| ->rowset_meta() | ||
| ->is_segments_overlapping()); | ||
|
|
||
| _tablet_reader_params.direct_mode = _aggregation || single_version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is useless?
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
7912b10 to
bec415f
Compare
| * For debugg purpose, skip delte predicate when reading data. | ||
| */ | ||
| @VariableMgr.VarAttr(name = SKIP_DELETE_PREDICATE) | ||
| private boolean skipDeletePredicate = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use public, or it may cause some serde probem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| * For debugg purpose, dont' merge unique key and agg key when reading data. | ||
| */ | ||
| @VariableMgr.VarAttr(name = SKIP_STORAGE_ENGINE_MERGE) | ||
| private boolean skipStorageEngineMerge = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is true, can we select DELETE_SIGN directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
bec415f to
e865bfb
Compare
…skip_storage_engine_merge` to treat agg and unique data model as dup model Also `skip_delete_predicate` session variable to skep delete predicates when reading table data.
e865bfb to
f520f2c
Compare
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…ms: add session variable skip_storage_engine_merge to treat agg and unique data model as dup model (apache#11952) For debug purpose: Add session variable skip_storage_engine_merge, when set to true, tables of aggregate key model and unique key model will be read as duplicate key model. Add session variable skip_delete_predicate, when set to true, rows deleted with delete statement will be selected.
Proposed changes
Issue Number: close #xxx
Problem summary
For debug purpose:
Add session variable
skip_storage_engine_merge, when set to true, tables of aggregate key model and unique key model will be read as duplicate key model.Add session variable
skip_delete_predicate, when set to true, rows deleted withdeletestatement will be selected.Test result( withc auto compaction off):
create test table and insert data:
initial session variables and data:
enable skip_storage_engine_merge and check select result, not merged original rows are returned:
turn off skip_storage_engine_merge
load delete and select again:
csv:
delete rows with
a = 2:enable skip_storage_engine_merge and select, rows deleted with
deletestatement is not returned:enable skip_delete_predicate, rows deleted with
deletestatement is also returned:Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...