Skip to content

Conversation

@jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Sep 14, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Related to #11952 , add regression test case for session variable skip_storage_engine_merge, skip_delete_predicate and show_hidden_columns.

Also add this function to new olap scan node.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…iable skip_storage_engine_merge, skip_delete_predicate and show_hidden_columns

also add this function to new olap scan node.
@jacktengg jacktengg force-pushed the skip_merge_add_test_case branch from bd0631f to 240fc60 Compare September 15, 2022 07:26
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 8364165 into apache:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants