Skip to content

Conversation

@chenlinzhong
Copy link
Contributor

@chenlinzhong chenlinzhong commented Sep 7, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

i think the quick compaction enabled by default is more beneficial for the system

more details see issue(#9804)

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@chenlinzhong chenlinzhong changed the title [feature](quick-compaciton) open quick compaction default [feature](quick-compaciton) open quick compactiony by default Sep 7, 2022
@chenlinzhong chenlinzhong changed the title [feature](quick-compaciton) open quick compactiony by default [feature](quick-compaciton) open quick compaction by default Sep 7, 2022
morningman
morningman previously approved these changes Sep 7, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenlinzhong chenlinzhong changed the title [feature](quick-compaciton) open quick compaction by default [feature](quick-compaciton) enable quick compaction by default Sep 7, 2022
@morningman morningman added kind/behavior-changed area/config Issues or PRs related to configuration labels Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 7, 2022
@hf200012
Copy link
Contributor

hf200012 commented Sep 7, 2022

@chenlinzhong rebase

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Mar 19, 2023
@github-actions github-actions bot closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to configuration kind/behavior-changed reviewed Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants