[fix](struct-type) fix some errors in data type factory create struct type #15906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| for (size_t i = 0; i < field_size; i++) { | ||
| dataTypes.push_back(create_data_type(*col_desc.get_sub_field(i))); | ||
| names.push_back(col_desc.name()); | ||
| names.push_back(col_desc.get_sub_field(i).name()); |
Contributor
There was a problem hiding this comment.
warning: member reference type 'doris::Field *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
Suggested change
| names.push_back(col_desc.get_sub_field(i).name()); | |
| names.push_back(col_desc.get_sub_field(i)->name()); |
| for (size_t i = 0; i < col_size; i++) { | ||
| dataTypes.push_back(create_data_type(col_desc.get_sub_column(i))); | ||
| names.push_back(col_desc.name()); | ||
| names.push_back(col_desc.get_sub_field(i).name()); |
Contributor
There was a problem hiding this comment.
warning: no member named 'get_sub_field' in 'doris::TabletColumn' [clang-diagnostic-error]
names.push_back(col_desc.get_sub_field(i).name());
^
xy720
added a commit
to xy720/doris
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...