Skip to content

[fix](struct-type) fix some errors in data type factory create struct type #15906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cambyzju merged 1 commit into from
Jan 13, 2023
Merged

[fix](struct-type) fix some errors in data type factory create struct type #15906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions be/src/vec/data_types/data_type_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ DataTypePtr DataTypeFactory::create_data_type(const doris::Field& col_desc) {
names.reserve(field_size);
for (size_t i = 0; i < field_size; i++) {
dataTypes.push_back(create_data_type(*col_desc.get_sub_field(i)));
names.push_back(col_desc.name());
names.push_back(col_desc.get_sub_field(i).name());
Copy link
Contributor

@github-actions github-actions bot Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: member reference type 'doris::Field *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]

Suggested change
names.push_back(col_desc.get_sub_field(i).name());
names.push_back(col_desc.get_sub_field(i)->name());

}
nested = std::make_shared<DataTypeStruct>(dataTypes, names);
} else {
Expand Down Expand Up @@ -64,7 +64,7 @@ DataTypePtr DataTypeFactory::create_data_type(const TabletColumn& col_desc, bool
names.reserve(col_size);
for (size_t i = 0; i < col_size; i++) {
dataTypes.push_back(create_data_type(col_desc.get_sub_column(i)));
names.push_back(col_desc.name());
names.push_back(col_desc.get_sub_field(i).name());
Copy link
Contributor

@github-actions github-actions bot Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no member named 'get_sub_field' in 'doris::TabletColumn' [clang-diagnostic-error]

            names.push_back(col_desc.get_sub_field(i).name());
                                     ^

}
nested = std::make_shared<DataTypeStruct>(dataTypes, names);
} else {
Expand Down Expand Up @@ -343,7 +343,7 @@ DataTypePtr DataTypeFactory::create_data_type(const PColumnMeta& pcolumn) {
names.reserve(col_size);
for (size_t i = 0; i < col_size; i++) {
dataTypes.push_back(create_data_type(pcolumn.children(i)));
names.push_back(pcolumn.name());
names.push_back(pcolumn.children(i).name());
}
nested = std::make_shared<DataTypeStruct>(dataTypes, names);
break;
Expand Down