Skip to content

[fix](struct-type) support to remove double or single quote #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cambyzju merged 1 commit into from
Jan 16, 2023
Merged

[fix](struct-type) support to remove double or single quote #15977

cambyzju merged 1 commit into from
Jan 16, 2023

Conversation

@carlvinhust2012
Copy link
Contributor

@carlvinhust2012 carlvinhust2012 commented Jan 16, 2023

Proposed changes

  1. this pr is used to support to remove double or single quote.
    Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. labels Jan 16, 2023
@carlvinhust2012 carlvinhust2012 changed the base branch from master to struct-type January 16, 2023 09:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023

clang-tidy review says "All clean, LGTM! 👍"

cambyzju
cambyzju approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023

PR approved by anyone and no changes requested.

@cambyzju cambyzju merged commit b5a048b into apache:struct-type Jan 16, 2023
@xy720 xy720 assigned xy720 and carlvinhust2012 and unassigned xy720 Jan 17, 2023
xy720 pushed a commit that referenced this pull request Feb 6, 2023
@carlvinhust2012
[fix](struct-type) support to remove double or single quote (#15977)
1f360b6
xy720 pushed a commit that referenced this pull request Feb 6, 2023
@carlvinhust2012
[fix](struct-type) support to remove double or single quote (#15977)
747cc04
xy720 pushed a commit that referenced this pull request Feb 9, 2023
@carlvinhust2012
[fix](struct-type) support to remove double or single quote (#15977)
20d377b
xy720 pushed a commit that referenced this pull request Feb 9, 2023
@carlvinhust2012
[fix](struct-type) support to remove double or single quote (#15977)
0f9be0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cambyzju cambyzju cambyzju approved these changes

Assignees

@carlvinhust2012 carlvinhust2012

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

Doris support struct+map type
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlvinhust2012 @cambyzju @xy720