Skip to content

[fix](struct-type) support to remove double or single quote #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cambyzju merged 1 commit into from
Jan 16, 2023
Merged

[fix](struct-type) support to remove double or single quote #15977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions be/src/vec/data_types/data_type_struct.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ Status DataTypeStruct::from_string(ReadBuffer& rb, IColumn* column) const {
return Status::InvalidArgument("Invalid Length");
}
ReadBuffer field_rb(rb.position(), field_len);

size_t len = 0;
auto start_rb = field_rb.position();
while (!field_rb.eof() && *start_rb != ':') {
Expand All @@ -122,11 +123,12 @@ Status DataTypeStruct::from_string(ReadBuffer& rb, IColumn* column) const {
}
ReadBuffer field(field_rb.position() + len + 1, field_rb.count() - len - 1);

if (field.count() < 2 || *field.position() != '"' || *field.end() != '"') {
field_rbs.push_back(field);
if (field.count() >= 2 && ((*field.position() == '"' && *(field.end() - 1) == '"') ||
(*field.position() == '\'' && *(field.end() - 1) == '\''))) {
ReadBuffer field_no_quote(field.position() + 1, field.count() - 2);
field_rbs.push_back(field_no_quote);
} else {
ReadBuffer field_has_quote(field.position() + 1, field.count() - 2);
field_rbs.push_back(field_has_quote);
field_rbs.push_back(field);
}

rb.position() += field_len + 1;
Expand Down