[refactor](refactor field) remove unused method #16068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| int32_t r_int_gt = 10; | ||
| right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt), _mem_pool.get()); | ||
| right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt), _mem_pool.get()); | ||
| EXPECT_GT(compare_row(left, right_gt), 0); |
Contributor
There was a problem hiding this comment.
warning: use of undeclared identifier 'compare_row' [clang-diagnostic-error]
EXPECT_GT(compare_row(left, right_gt), 0);
^
Contributor
|
TeamCity pipeline, clickbench performance test result: |
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 1, 2023
dataroaring
pushed a commit
that referenced
this pull request
Jul 20, 2024
SegcompactionTest is disabled by #16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dataroaring
pushed a commit
that referenced
this pull request
Jul 22, 2024
SegcompactionTest is disabled by #16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Jul 22, 2024
SegcompactionTest is disabled by apache#16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Aug 9, 2024
SegcompactionTest is disabled by apache#16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...