-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](ut) repair segcompaction ut #38165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
846df8b to
e0d4e37
Compare
|
run buildall |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 40158 ms |
TPC-DS: Total hot run time: 173129 ms |
ClickBench: Total hot run time: 30.4 s |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39622 ms |
TPC-DS: Total hot run time: 174086 ms |
ClickBench: Total hot run time: 30.59 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
SegcompactionTest is disabled by #16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SegcompactionTest is disabled by apache#16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SegcompactionTest is disabled by apache#16068 due to some code clean up, it needs to be repaired --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Proposed changes
Issue Number: close #xxx
SegcompactionTest is disabled by #16068 due to some code clean up, it needs to be repaired