[Enhancement](storage) add a new hidden column __DORIS_VERSION_COL__ for unique key table #16509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/planner
zhannngchen
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
zhannngchen
force-pushed
the
add_version_col
branch
from
8ab0c83 to
7eeeae8
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
zhannngchen
force-pushed
the
add_version_col
branch
from
57755ab to
fbdc23c
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
zhannngchen
force-pushed
the
add_version_col
branch
from
fbdc23c to
d7236b8
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…for unique key table
zhannngchen
force-pushed
the
add_version_col
branch
from
d7236b8 to
67d0169
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
run compile |
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Feb 24, 2023
…for unique key table (apache#16509)
Merged
5 tasks
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
…for unique key table (apache#16509)
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
Mar 18, 2025
…placed by fake version when merging tmp rowset in sort SC (#49193) ### What problem does this PR solve? When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like `[2^29+x, 2^29+x]`, so the values of `__DORIS_VERSION_COL__` in these temp rowsets will be wrongly replaced by these fake version(see #16509) in `Merger::vmerge_rowsets` when merging them into a single rowset. This PR modify these fake versions to avoid it.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…placed by fake version when merging tmp rowset in sort SC (#49193) ### What problem does this PR solve? When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like `[2^29+x, 2^29+x]`, so the values of `__DORIS_VERSION_COL__` in these temp rowsets will be wrongly replaced by these fake version(see #16509) in `Merger::vmerge_rowsets` when merging them into a single rowset. This PR modify these fake versions to avoid it.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…placed by fake version when merging tmp rowset in sort SC (apache#49193) ### What problem does this PR solve? When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like `[2^29+x, 2^29+x]`, so the values of `__DORIS_VERSION_COL__` in these temp rowsets will be wrongly replaced by these fake version(see apache#16509) in `Merger::vmerge_rowsets` when merging them into a single rowset. This PR modify these fake versions to avoid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Only added to unique key table.
We've meet some data inconsistent issues, with this version column, it's much easier to locate issue.
For example:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...