-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](SC) Prevent the values of __DORIS_VERSION_COL__ be wrongly replaced by fake version when merging tmp rowset in sort SC
#49193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32608 ms |
TPC-DS: Total hot run time: 186121 ms |
ClickBench: Total hot run time: 31.39 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…placed by fake version when merging tmp rowset in sort SC (#49193) ### What problem does this PR solve? When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like `[2^29+x, 2^29+x]`, so the values of `__DORIS_VERSION_COL__` in these temp rowsets will be wrongly replaced by these fake version(see #16509) in `Merger::vmerge_rowsets` when merging them into a single rowset. This PR modify these fake versions to avoid it.
…placed by fake version when merging tmp rowset in sort SC (apache#49193) ### What problem does this PR solve? When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like `[2^29+x, 2^29+x]`, so the values of `__DORIS_VERSION_COL__` in these temp rowsets will be wrongly replaced by these fake version(see apache#16509) in `Merger::vmerge_rowsets` when merging them into a single rowset. This PR modify these fake versions to avoid it.
…__` be wrongly replaced by fake version when merging tmp rowset in sort SC apache#49193 (apache#49222) (apache#335) pick apache#49193
What problem does this PR solve?
When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like
[2^29+x, 2^29+x], so the values of__DORIS_VERSION_COL__in these temp rowsets will be wrongly replaced by these fake version(see #16509) inMerger::vmerge_rowsetswhen merging them into a single rowset.This PR modify these fake versions to avoid it.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)