-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Opt](checksum) Add an config to skip __DORIS_VERSION_COL__ when calculate checksum
#49154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Opt](checksum) Add an config to skip __DORIS_VERSION_COL__ when calculate checksum
#49154
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32686 ms |
TPC-DS: Total hot run time: 185087 ms |
ClickBench: Total hot run time: 31.65 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32812 ms |
TPC-DS: Total hot run time: 193552 ms |
f941903 to
a141d5c
Compare
|
run buildall |
TPC-H: Total hot run time: 32576 ms |
TPC-DS: Total hot run time: 185554 ms |
ClickBench: Total hot run time: 30.79 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
fix in #49193 |
What problem does this PR solve?
sometimes there may be confusing but not totally random values in
__DORIS_VERSION_COL__(such as2^29, 2^29+1) on tablets which have schema change before. And this will lead to checksums of tablets inconsistent between replicas. This PR__DORIS_VERSION_COL__column when calculating checksum to avoid this problem.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)