branch-3.0: [Fix](SC) Prevent the values of __DORIS_VERSION_COL__ be wrongly replaced by fake version when merging tmp rowset in sort SC #49193
#49219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placed by fake version when merging tmp rowset in sort SC (#49193) ### What problem does this PR solve? When converting historical rowsets in sort schema change, it may write many temp rowsets and merge them into one rowset later if memory is not enough. However, these rowsets have fake versions which are like `[2^29+x, 2^29+x]`, so the values of `__DORIS_VERSION_COL__` in these temp rowsets will be wrongly replaced by these fake version(see #16509) in `Merger::vmerge_rowsets` when merging them into a single rowset. This PR modify these fake versions to avoid it.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #49193