[Feature](Dynamic schema table) step1 support schema change expression #17494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/load
eldenmoon
force-pushed
the
dynamic-table-x
branch
from
c62c45f to
a955e85
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
run buildall |
eldenmoon
force-pushed
the
dynamic-table-x
branch
from
a955e85 to
1dcc39b
Compare
Member
Author
|
run buildall |
xiaokang
reviewed
Mar 10, 2023
gensrc/thrift/Exprs.thrift
Outdated
| 29: optional bool is_nullable | ||
|
|
||
| 30: optional TJsonLiteral json_literal | ||
| 31: optional TSchemaChangeInfo schema_change_info |
Contributor
There was a problem hiding this comment.
It't somewhat strange that Expr has schema_change_info.
Member
Author
There was a problem hiding this comment.
renamed to TSchemaChangeExpr
fe/fe-core/src/main/java/org/apache/doris/analysis/SchemaChangeExpr.java
Outdated
Show resolved
Hide resolved
| msg.node_type = TExprNodeType.SCHEMA_CHANGE_EXPR; | ||
| // set type info | ||
| TTypeDesc desc = new TTypeDesc(); | ||
| desc.setTypes(new ArrayList<TTypeNode>()); |
Contributor
There was a problem hiding this comment.
what's the function of setTypes to an emply list?
Member
Author
There was a problem hiding this comment.
variant.toThrift(desc) will add TTypeNode to the empty list
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadingTaskPlanner.java
Show resolved
Hide resolved
| } | ||
| size_t operator()(const Int64& x) { | ||
| // Only support Int32 and Int64 | ||
| // Only Int64 at present |
Contributor
There was a problem hiding this comment.
why delete support for Int32
Member
Author
There was a problem hiding this comment.
since int32 is not enough to hold values when user first load int value then load bigint value, the bigint values will be overflow
| column_object.finalize(); | ||
| // flatten object columns for the purpose of extracting static columns and | ||
| // fill default values missing in static columns | ||
| schema_util::unfold_object(columns.size() - 1, columns, _slot_desc_index, slot_descs, |
Contributor
There was a problem hiding this comment.
there is no flatten_object before, why add unfold_object?
Member
Author
There was a problem hiding this comment.
flatten renamed to unfold
1. introduce a new type `VARIANT` to encapsulate dynamic generated columns for hidding the detail of types and names of newly generated columns 2. introduce a new expression `SchemaChangeExpr` for doing schema change for extensibility
eldenmoon
force-pushed
the
dynamic-table-x
branch
from
ac1fcb0 to
fd66af8
Compare
Member
Author
|
run buildall |
Member
Author
|
run p0 |
Contributor
|
PR approved by anyone and no changes requested. |
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
* [WIP](dynamic-table) support dynamic schema table (apache#16335) Issue Number: close apache#16351 Dynamic schema table is a special type of table, it's schema change with loading procedure.Now we implemented this feature mainly for semi-structure data such as JSON, since JSON is schema self-described we could extract schema info from the original documents and inference the final type infomation.This speical table could reduce manual schema change operation and easily import semi-structure data and extends it's schema automatically. * [improve](dynamic-table) change `addColumns` RPC interface fields from `required` to `optional` and and config doc (apache#16632) * [doc](dynamic-table) Add docs for dynamic-table (apache#16669) * [improve](dynamic table) refine SegmentWriter columns writer generate (apache#16816) * [improve](dynamic table) refine SegmentWriter columns writer generate ``` Dynamic Block consists of two parts, dynamic part of columns and static part of columns static dynamic | ----- | ------- | the static ones are original _tablet_schame columns the dynamic ones are auto generated and extended from file scan. ``` **We should only consisder to use Block info to generte columns when it's a dynamic table load procudure.** And seperate the static ones and dynamic ones * test * [typo](docs)fix dynamic Table version label (apache#16895) * [Feature](Dynamic schema table) step1 support schema change expression (apache#17494) 1. introduce a new type `VARIANT` to encapsulate dynamic generated columns for hidding the detail of types and names of newly generated columns 2. introduce a new expression `SchemaChangeExpr` for doing schema change for extensibility * Fix compile * [Bug](dynamic-table) Fix column alignment logic and support filtering null values when slot is not null Before this PR when encountering null values with some columns which is specified as `NOT NULL`, null values will not be filtered,thi behavior does not match with the original load behavior. Second column alignment logic has bug : ``` template <typename ColumnInserterFn> void align_variant_by_name_and_type(ColumnObject& dst, const ColumnObject& src, size_t row_cnt, ColumnInserterFn inserter) { CHECK(dst.is_finalized() && src.is_finalized()); // Use rows() here instead of size(), since size() will check_consistency // but we could not check_consistency since num_rows will be upgraded even // if src and dst is empty, we just increase the num_rows of dst and fill // num_rows of default values when meet new data size_t num_rows = dst.rows(); ``` --------- Co-authored-by: jiafeng.zhang <zhangjf1@gmail.com>
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
apache#17494) 1. introduce a new type `VARIANT` to encapsulate dynamic generated columns for hidding the detail of types and names of newly generated columns 2. introduce a new expression `SchemaChangeExpr` for doing schema change for extensibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VARIANTto encapsulate dynamic generated columns for hidding the detail of types and names of newly generated columnsSchemaChangeExprfor doing schema change for extensibilityProposed changes
Issue Number: close #17493
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...