Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Mar 28, 2023

Proposed changes

ref #16547

This commit will support struct constructor function.

need to merge #18392 first.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Mar 28, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@xy720 xy720 force-pushed the support-struct-functions branch from 0995218 to f4d61db Compare April 4, 2023 17:58
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xy720
Copy link
Member Author

xy720 commented Apr 6, 2023

run buildall

cambyzju
cambyzju previously approved these changes Apr 6, 2023
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 11, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720 xy720 force-pushed the support-struct-functions branch from 330ce8e to 65336c5 Compare April 11, 2023 12:02
@xy720
Copy link
Member Author

xy720 commented Apr 11, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720
Copy link
Member Author

xy720 commented Apr 12, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 12, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@xy720 xy720 merged commit d57371d into apache:master Apr 13, 2023
@xy720 xy720 mentioned this pull request Apr 13, 2023
88 tasks
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…che#18190)

This commit will support struct and named_struct function.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…che#18190)

This commit will support struct and named_struct function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants