Fix parquet_scanner_test in debug mode #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Sep 27, 2019
| } | ||
| SlotDescriptor* slot_descriptor = _src_slot_descs_order_by_dest[dest_index]; | ||
| if (_strict_mode && (slot_descriptor != nullptr)&& !_src_tuple->is_null(slot_descriptor->null_indicator_offset())) { | ||
| if (_strict_mode && (_src_slot_descs_order_by_dest[dest_index] != nullptr) && |
Contributor
There was a problem hiding this comment.
better leave a comment for this change, I'm afraid other will change it back someday.
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…ble apache#19970 (apache#20512)" (apache#1900) should cancel query during hash table build stage if the query is cancelled. pick apache#19970 Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_src_slot_descs_order_by_dest size could be sero.