Skip to content

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented May 23, 2023

Proposed changes

should cancel query during hash table build stage if the query is cancelled.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz xinyiZzz force-pushed the 20230524_fix_join_build_cancel branch from 6a49735 to c97ca37 Compare May 24, 2023 02:15
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

run buildall

@yiguolei yiguolei merged commit 14b4c7a into apache:master May 24, 2023
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Jun 6, 2023
…ache#19970

should cancel query during hash table build stage if the query is cancelled.
yiguolei pushed a commit that referenced this pull request Jun 7, 2023
…9970 (#20512)

should cancel query during hash table build stage if the query is cancelled.
Issue Number: close #xxx

pick #19970
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…ache#19970 (apache#20512)

should cancel query during hash table build stage if the query is cancelled.
Issue Number: close #xxx

pick apache#19970
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
…ble apache#19970 (apache#20512)" (apache#1900)

should cancel query during hash table build stage if the query is cancelled.

pick apache#19970

Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants