-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](hashtable) Check query cancel status during build hash table #19970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yiguolei
merged 1 commit into
apache:master
from
xinyiZzz:20230524_fix_join_build_cancel
May 24, 2023
Merged
[fix](hashtable) Check query cancel status during build hash table #19970
yiguolei
merged 1 commit into
apache:master
from
xinyiZzz:20230524_fix_join_build_cancel
May 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
yiguolei
reviewed
May 24, 2023
yiguolei
reviewed
May 24, 2023
yiguolei
reviewed
May 24, 2023
yiguolei
reviewed
May 24, 2023
6a49735 to
c97ca37
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
approved these changes
May 24, 2023
Contributor
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Jun 6, 2023
…ache#19970 should cancel query during hash table build stage if the query is cancelled.
yiguolei
pushed a commit
that referenced
this pull request
Jun 7, 2023
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…ache#19970 (apache#20512) should cancel query during hash table build stage if the query is cancelled. Issue Number: close #xxx pick apache#19970
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…ble apache#19970 (apache#20512)" (apache#1900) should cancel query during hash table build stage if the query is cancelled. pick apache#19970 Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/vectorization
dev/1.2.5-merged
need-cherry-pick
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
should cancel query during hash table build stage if the query is cancelled.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...