-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement](delete) eliminate reading the old values of non-key columns for delete stmt #22270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run arm |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
regression-test/suites/unique_with_mow_p0/partial_update/test_partial_update_delete.groovy
Show resolved
Hide resolved
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run clickbench |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…umns for delete stmt (#22270)
…umns for delete stmt in publish phase (apache#38703) apache#22270 should also do in pulish phase
Proposed changes
Currently, when executing
insert into selectstatement converted from a delete statement, doris will try to read all the values of the non-key columns from the previous rows with the same key in storage layer, which is highly costly and meaningless.For example, for a table with the following schema
and data
after execute some delete statement(which is transformed to
insert into selectstatement) that delete rows with k1=1,2,3, the data with delete_sign column will be likeIt's evitable that it reads lots of useless data. So this PR eliminates the above process and use default or null value to fill the non-key columns when inserting rows with marked delete sign, since the values in these columns are useless and will not be read.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...