-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Feature](fe) Add admin set partition version statement #23086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
some docs still need to be updated |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add regression test case.
Eg, if a partition's version is 3,
- set it to 2
- set it to 3
- check if table can query
- load some data
- check if table can query
fe/fe-core/src/main/java/org/apache/doris/persist/SetPartitionVersionOperationLog.java
Outdated
Show resolved
Hide resolved
d93946d to
bc47cb5
Compare
|
run buildall |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
chenlinzhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
|
run clickbench |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
chenlinzhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
adonis0147
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit add a statement to modify partition visible version.
This commit add a statement to modify partition visible version.
|
revert this PR in branch-2.0 since it modify fe metadata OperationType and cause rollback from 2.0.2 to 2.0.1/2.0.0 |
…)" This reverts commit 5442d9a.
Proposed changes
Last week, we encountered a situation where we had to recover master's metadata from image without bdbje log.
After recovering the master, we found that the partition visible version of the master's metadata was inconsistent with the actual replica in Be.
This commit add a statement to modify partition visible version.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...