Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Aug 17, 2023

Proposed changes

Last week, we encountered a situation where we had to recover master's metadata from image without bdbje log.
After recovering the master, we found that the partition visible version of the master's metadata was inconsistent with the actual replica in Be.

This commit add a statement to modify partition visible version.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720
Copy link
Member Author

xy720 commented Aug 17, 2023

run buildall

@xy720
Copy link
Member Author

xy720 commented Aug 17, 2023

some docs still need to be updated

@xy720
Copy link
Member Author

xy720 commented Aug 18, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.74 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162140296 Bytes

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression test case.
Eg, if a partition's version is 3,

  1. set it to 2
  2. set it to 3
  3. check if table can query
  4. load some data
  5. check if table can query

@xy720 xy720 force-pushed the admin-set-partition-properties branch from d93946d to bc47cb5 Compare August 24, 2023 07:40
@xy720
Copy link
Member Author

xy720 commented Aug 24, 2023

run buildall

@xy720
Copy link
Member Author

xy720 commented Aug 24, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.13 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162305756 Bytes

@xy720
Copy link
Member Author

xy720 commented Aug 24, 2023

@morningman

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.07 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17161946626 Bytes

morningman
morningman previously approved these changes Aug 26, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

chenlinzhong
chenlinzhong previously approved these changes Aug 28, 2023
Copy link
Contributor

@chenlinzhong chenlinzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 dismissed stale reviews from chenlinzhong and morningman via bc448e8 August 28, 2023 02:24
@xy720
Copy link
Member Author

xy720 commented Aug 28, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 28, 2023
@xy720
Copy link
Member Author

xy720 commented Aug 28, 2023

run clickbench

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.97 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162209572 Bytes

Copy link
Contributor

@chenlinzhong chenlinzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit 4c8fc06 into apache:master Aug 28, 2023
xiaokang pushed a commit that referenced this pull request Aug 30, 2023
This commit add a statement to modify partition visible version.
morningman pushed a commit to morningman/doris that referenced this pull request Aug 31, 2023
This commit add a statement to modify partition visible version.
@xiaokang
Copy link
Contributor

revert this PR in branch-2.0 since it modify fe metadata OperationType and cause rollback from 2.0.2 to 2.0.1/2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants