Skip to content

Conversation

@mongo360
Copy link
Contributor

@mongo360 mongo360 commented Jun 3, 2024

delete same mismatched sql manual doc for 2.0 in Database-Administration-Statements

This 3 admin command does not implement in 2.0 version:

  1. ADMIN-SET-PARTITION-VERSION
    related pr: [Feature](fe) Add admin set partition version statement doris#23086
  2. ADMIN-SET-REPLICA-VERSION
    related pr: [feature](replica version) Add admin set replica version statement doris#23706
  3. ADMIN-SET-TABLE-STATUS
    related pr: [Feature](fe) Add admin set table status statement doris#23139

replicate:
test table

MySQL [db]> create table a_table(
    k1 BIGINT NOT NULL,
    k2 DATE NOT NULL,
    k3 VARCHAR(100) NOT NULL,
    v1 INT SUM NULL DEFAULT "0"
) ENGINE=OLAP
AGGREGATE KEY(k1,k2,k3)
PARTITION BY RANGE(`k2`)
(PARTITION pbefore202305 VALUES [('1900-01-01'), ('2023-05-01')),
PARTITION p202305 VALUES [('2023-05-01'), ('2023-06-01')),
PARTITION p202306 VALUES [('2023-06-01'), ('2023-07-01')))
distributed BY hash(k1) buckets 2
properties("replication_num" = "1");
MySQL [db]> insert into a_table values (10, '2023-06-05', 'view', 100);
  1. ADMIN-SET-PARTITION-VERSION test
MySQL [db]> admin set table a_table partition version properties ('partition_id'="10086", "visible_version" = "2");
ERROR 1105 (HY000): errCode = 2, detailMessage = Syntax error in line 1:
admin set table a_table partition vers...
          ^
Encountered: TABLE
Expected
  1. ADMIN-SET-REPLICA-VERSION test
MySQL [db]> ADMIN SET REPLICA VERSION PROPERTIES("tablet_id" = "10097", "backend_id" = "10012", "last_failed_version" = "-1");
ERROR 1105 (HY000): errCode = 2, detailMessage = Syntax error in line 1:
ADMIN SET REPLICA VERSION PROPERTIES("tablet_i...
                  ^
Encountered: VERSION
Expected
  1. ADMIN-SET-TABLE-STATUS test
MySQL [db]> admin set table a_table status properties("state" = "NORMAL");
ERROR 1105 (HY000): errCode = 2, detailMessage = Syntax error in line 1:
admin set table a_table status propert...
          ^
Encountered: TABLE
Expected

@mongo360 mongo360 changed the title delete sql manual docs that mismatched of code in 2.0 [doc]delete sql manual docs that mismatched of code in 2.0 Jun 3, 2024
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also delete them in sidebars.json

@mongo360 mongo360 force-pushed the fix_invalid_sql_manual_doc_for_2.0 branch from 9ac2bf8 to 133a221 Compare June 5, 2024 01:57
@mongo360
Copy link
Contributor Author

mongo360 commented Jun 5, 2024

please also delete them in sidebars.json

@zclllyybb done

@luzhijing
Copy link
Contributor

Thank you for your contribution. Could you please elaborate on the specific manifestations of the mismatch between these documents and the code? Please provide a detailed explanation.

@mongo360
Copy link
Contributor Author

mongo360 commented Jun 5, 2024

Thank you for your contribution. Could you please elaborate on the specific manifestations of the mismatch between these documents and the code? Please provide a detailed explanation.

@luzhijing added

@mongo360 mongo360 requested a review from zclllyybb June 5, 2024 05:24
Copy link
Contributor

@luzhijing luzhijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luzhijing luzhijing merged commit e922991 into apache:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants