[Feature](fe) Add admin set table status statement #23139
Conversation
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 |
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
Please add regression test case.
You can set a table's state to , eg, rollup and set it back to normal
|
|
||
| checkProperties(); | ||
| // only support changing table state to normal | ||
| // if (tableState != OlapTableState.NORMAL) { |
There was a problem hiding this comment.
Useless code. It has been removed
| @SerializedName(value = "table") | ||
| private String table; | ||
| @Getter | ||
| @SerializedName(value = "tabletId") |
There was a problem hiding this comment.
| @SerializedName(value = "tabletId") | |
| @SerializedName(value = "state") |
|
run buildall |
|
regression test has been added, please cc @morningman |
|
run compile |
|
run buildall |
xy720
force-pushed
the
admin-set-table-status
branch
from
2498360 to
68c240d
Compare
|
run buildall |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
For some certain bugs, jobs is stuck in FE by the table state. For example, There is a bug which causes table remains ROLLUP state after adding rollup job, then other alter jobs later will not succeed because the table state is always ROLLUP but not NORMAL. This commit adds a statement which is used to set the state of the specified table.
|
revert this PR in branch-2.0 since it modify fe metadata OperationType and cause rollback from 2.0.2 to 2.0.1/2.0.0 |
5 participants
Proposed changes
For some certain bugs, jobs is stuck in FE by the table state. For example, There is a bug which causes table remains ROLLUP state after adding rollup job, then other alter jobs later will not succeed because the table state is always ROLLUP but not NORMAL.
This commit adds a statement which is used to set the state of the specified table.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...