[opt](Nereids) remove between expression to simplify planner #23421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrySnow
force-pushed
the
fix_between_type_coercion
branch
from
184ada8 to
f2ec245
Compare
Contributor
Author
|
run buildall |
Contributor
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morrySnow
force-pushed
the
fix_between_type_coercion
branch
from
f2ec245 to
e258634
Compare
morrySnow
force-pushed
the
fix_between_type_coercion
branch
from
e258634 to
fbef81b
Compare
Contributor
Author
|
run buildall |
starocean999
approved these changes
Aug 25, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
keanji-x
approved these changes
Aug 25, 2023
xiaokang
pushed a commit
that referenced
this pull request
Aug 25, 2023
Closed
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Feb 19, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Feb 19, 2025
16 tasks
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Feb 24, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Feb 26, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Feb 28, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Mar 3, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 28, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 29, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 31, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 31, 2025
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 31, 2025
16 tasks
924060929
pushed a commit
that referenced
this pull request
Sep 1, 2025
in logical plan builder, there are bugs with between: - for sql `a between random() and random()`, since the two unbound `'random()` are the same, it will rewrite to `a = random()`, but the two random() should be different after bind expression; - for sql `random() between 0.1 and 0.5`, it will rewrite to `random() >= 0.1 and random() <= 0.5`, later when bind expression, the two unbound random() will generate two different bounded random() function, but the two random() need to be the same. so, in logical plan builder, the between shouldn't compare low bound and upper bound, and should not expand before bind expression. relate PR: 1) unique function: #54414 2) remove between: #23421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...