[fix](unique function) add between back for fix unique function #55407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
4 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
16 tasks
TPC-H: Total hot run time: 34803 ms |
TPC-DS: Total hot run time: 187196 ms |
ClickBench: Total hot run time: 32.97 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34390 ms |
TPC-DS: Total hot run time: 187413 ms |
ClickBench: Total hot run time: 32.49 s |
Contributor
Author
|
run p0 |
2 similar comments
Contributor
Author
|
run p0 |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
yujun777
force-pushed
the
add-between-back-2
branch
from
e9ea359 to
c469e06
Compare
yujun777
force-pushed
the
add-between-back-2
branch
from
c469e06 to
c97458f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34427 ms |
TPC-DS: Total hot run time: 187103 ms |
ClickBench: Total hot run time: 33.16 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
924060929
approved these changes
Sep 1, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Sep 1, 2025
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Sep 5, 2025
### What problem does this PR solve? If an unique function exists multiple times, then be will calculate it multiple times for each row, so it will be error. for example: `filter(random() between 10 and 20)`, after rewrite the `between`, it will get `filter(random() >= 10 and random() <= 20)`, this will contains two random in one expression, the two RANDOM should be one, so we add a project, then we can get `filter(k >= 10 and k <= 20) -> project(random() as k)` this PR also fix BETWEEN expression bug introduced by #55407 - between shouldn't be PropagateNullable because FoldConstantRuleOnFE will rewrite a propagate nullable expression to null if any children is NULL, but for sql `10 between null and 5` should be `FALSE`, not `NULL`; - after analyzed between expression, it will get an AND expression, then anlyzed join other conjunctions, need to extract conjuncts of each analyzed other conjunction (that is flattern AND).
wenzhenghu
pushed a commit
to wenzhenghu/doris
that referenced
this pull request
Sep 8, 2025
### What problem does this PR solve? If an unique function exists multiple times, then be will calculate it multiple times for each row, so it will be error. for example: `filter(random() between 10 and 20)`, after rewrite the `between`, it will get `filter(random() >= 10 and random() <= 20)`, this will contains two random in one expression, the two RANDOM should be one, so we add a project, then we can get `filter(k >= 10 and k <= 20) -> project(random() as k)` this PR also fix BETWEEN expression bug introduced by apache#55407 - between shouldn't be PropagateNullable because FoldConstantRuleOnFE will rewrite a propagate nullable expression to null if any children is NULL, but for sql `10 between null and 5` should be `FALSE`, not `NULL`; - after analyzed between expression, it will get an AND expression, then anlyzed join other conjunctions, need to extract conjuncts of each analyzed other conjunction (that is flattern AND).
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Jan 20, 2026
…`betweenAnd` expression class and included some work related to unique functions. This time, the pick only included the changes related to `betweenAnd`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
in logical plan builder, there are bugs with between:
a between random() and random(), since the two unbound'random()are the same, it will rewrite toa = random(), but the two random() should be different after bind expression;random() between 0.1 and 0.5, it will rewrite torandom() >= 0.1 and random() <= 0.5, later when bind expression, the two unbound random() will generate two different bounded random() function, but the two random() need to be the same.so, in logical plan builder, the between shouldn't compare low bound and upper bound, and should not expand before bind expression.
relate PR:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)