[feat](unique function) add project for unique function #48449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
yujun777
changed the title
yujun777
force-pushed
the
nonfoldable-add-project
branch
2 times, most recently
from
1a14013 to
3e77ec9
Compare
yujun777
force-pushed
the
nonfoldable-add-project
branch
from
3e77ec9 to
3d89334
Compare
yujun777
changed the title
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34297 ms |
TPC-DS: Total hot run time: 187103 ms |
ClickBench: Total hot run time: 33.03 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34135 ms |
TPC-DS: Total hot run time: 186740 ms |
ClickBench: Total hot run time: 32.24 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morrySnow
reviewed
Sep 1, 2025
| // extract unique function which exist multiple times from targets, | ||
| // then alias the unique function and put them into a child project, | ||
| // then rewrite targets with the alias names. | ||
| private <T extends Expression> Optional<Pair<List<T>, LogicalProject<Plan>>> rewriteExpressions( |
Contributor
There was a problem hiding this comment.
add UT for these functions
924060929
reviewed
Sep 1, 2025
| // if a unique function exists multiple times in the targets, then add a project to alias it. | ||
| private List<NamedExpression> tryGenUniqueFunctionAlias(Collection<? extends Expression> targets) { | ||
| Map<UniqueFunction, Integer> unqiueFunctionCounter = Maps.newLinkedHashMap(); | ||
| targets.forEach(target -> target.foreach(e -> { |
Contributor
There was a problem hiding this comment.
use for to instead forEach
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34441 ms |
TPC-DS: Total hot run time: 186731 ms |
ClickBench: Total hot run time: 32.55 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
yujun777
force-pushed
the
nonfoldable-add-project
branch
from
6cd8006 to
4b43e8f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34170 ms |
TPC-DS: Total hot run time: 187515 ms |
ClickBench: Total hot run time: 32.9 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run external |
924060929
approved these changes
Sep 5, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Sep 5, 2025
wenzhenghu
pushed a commit
to wenzhenghu/doris
that referenced
this pull request
Sep 8, 2025
### What problem does this PR solve? If an unique function exists multiple times, then be will calculate it multiple times for each row, so it will be error. for example: `filter(random() between 10 and 20)`, after rewrite the `between`, it will get `filter(random() >= 10 and random() <= 20)`, this will contains two random in one expression, the two RANDOM should be one, so we add a project, then we can get `filter(k >= 10 and k <= 20) -> project(random() as k)` this PR also fix BETWEEN expression bug introduced by apache#55407 - between shouldn't be PropagateNullable because FoldConstantRuleOnFE will rewrite a propagate nullable expression to null if any children is NULL, but for sql `10 between null and 5` should be `FALSE`, not `NULL`; - after analyzed between expression, it will get an AND expression, then anlyzed join other conjunctions, need to extract conjuncts of each analyzed other conjunction (that is flattern AND).
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Jan 20, 2026
…`betweenAnd` expression class and included some work related to unique functions. This time, the pick only included the changes related to `betweenAnd`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If an unique function exists multiple times, then be will calculate it multiple times for each row, so it will be error.
for example:
filter(random() between 10 and 20), after rewrite thebetween, it will getfilter(random() >= 10 and random() <= 20), this will contains two random in one expression, the two RANDOM should be one, so we add a project, then we can getfilter(k >= 10 and k <= 20) -> project(random() as k)this PR also fix BETWEEN expression bug introduced by #55407
10 between null and 5should beFALSE, notNULL;Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)