Skip to content

Revert "[Feature](merge-on-write)Support ignore mode for merge-on-write unique table (#21773)" #24731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 1 commit into from
Sep 21, 2023
Merged

Revert "[Feature](merge-on-write)Support ignore mode for merge-on-write unique table (#21773)" #24731

zhannngchen merged 1 commit into from
Sep 21, 2023

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Sep 21, 2023

Proposed changes

This reverts commit 3ee89ae.
We think ignore mode may be too complicate to support after discussion, so we disable it currently.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 21, 2023

run buildall

zhannngchen
zhannngchen previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

PR approved by anyone and no changes requested.

@bobhan1 bobhan1 force-pushed the revert-insert-ignore branch from df03f77 to 84e73d0 Compare September 21, 2023 08:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 21, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 21, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.75 seconds
stream load tsv: 592 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162225535 Bytes

@doris-robot
Copy link

doris-robot commented Sep 21, 2023

TeamCity be ut coverage result:
Function Coverage: 36.40% (8016/22023)
Line Coverage: 28.68% (64352/224343)
Region Coverage: 27.58% (33402/121131)
Branch Coverage: 24.24% (17095/70524)
Coverage Report: http://coverage.selectdb-in.cc/coverage/df03f778d74c97ab0cd6b6a4c214aa036e6efa98_df03f778d74c97ab0cd6b6a4c214aa036e6efa98/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 21, 2023

TeamCity be ut coverage result:
Function Coverage: 36.40% (8016/22023)
Line Coverage: 28.68% (64346/224343)
Region Coverage: 27.58% (33407/121131)
Branch Coverage: 24.24% (17097/70524)
Coverage Report: http://coverage.selectdb-in.cc/coverage/84e73d04fe35a960c93a7221f96d126dfd81ab41_84e73d04fe35a960c93a7221f96d126dfd81ab41/report/index.html

@bobhan1 bobhan1 requested a review from zhannngchen September 21, 2023 10:59
zhannngchen
zhannngchen approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 58ab25c into apache:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1 @doris-robot @zhannngchen @Yukang-Lian @dataroaring