Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 12, 2023

Proposed changes

This PR add support for ignore mode for merge-on-write unique table. It can be used in native insert statement(insert ignore into ...) or stream load. When the ignore mode is enabled, if the inserted row with key which exists in the table, the row data will be dicarded. If a inserted row with key which doesn't exist in table, the row data will be inserted.
The ignore mode is only available in mow unique table without sequence column and can't be used in a partial update.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/nereids area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. kind/test labels Jul 12, 2023
@bobhan1 bobhan1 marked this pull request as ready for review July 12, 2023 16:18
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 12, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.47 seconds
stream load tsv: 503 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17170840524 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713011400_clickbench_pr_177520.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 12, 2023

run p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 13, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.23 seconds
stream load tsv: 502 seconds loaded 74807831229 Bytes, about 142 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17170075550 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713103658_clickbench_pr_177635.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 13, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51 seconds
stream load tsv: 502 seconds loaded 74807831229 Bytes, about 142 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17169589207 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713113153_clickbench_pr_177724.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 13, 2023

run feet

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 13, 2023

run feut

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 13, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.48 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17163498312 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230714004533_clickbench_pr_178193.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 18, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 14, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.94% (7972/21581)
Line Coverage: 28.89% (63850/221004)
Region Coverage: 27.83% (33151/119130)
Branch Coverage: 24.39% (17009/69728)
Coverage Report: http://coverage.selectdb-in.cc/coverage/79a3b212a4fbdc98617d7464c44bee576c95fa14_79a3b212a4fbdc98617d7464c44bee576c95fa14/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.13 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162243718 Bytes

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zhannngchen zhannngchen merged commit 3ee89ae into apache:master Sep 14, 2023
bobhan1 added a commit to bobhan1/doris that referenced this pull request Sep 21, 2023
bobhan1 added a commit to bobhan1/doris that referenced this pull request Sep 21, 2023
zhannngchen pushed a commit that referenced this pull request Sep 21, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 20, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 20, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 20, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 21, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 22, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 22, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 22, 2023
yuxuan-luo pushed a commit to yuxuan-luo/doris that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load area/nereids area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants