[Feature](merge-on-write)Support ignore mode for merge-on-write uniqu… #27365
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/src/olap/tablet_meta.cpp
Outdated
| void DeleteBitmap::subset_ignore(const BitmapKey& start, const BitmapKey& end, | ||
| DeleteBitmap* subset_rowset_map) const { |
There was a problem hiding this comment.
warning: method 'subset_ignore' can be made static [readability-convert-member-functions-to-static]
| void DeleteBitmap::subset_ignore(const BitmapKey& start, const BitmapKey& end, | |
| DeleteBitmap* subset_rowset_map) const { | |
| static void DeleteBitmap::subset_ignore(const BitmapKey& start, const BitmapKey& end, | |
| DeleteBitmap* subset_rowset_map) { |
| void DeleteBitmap::subset_ignore(const BitmapKey& start, const BitmapKey& end, | ||
| DeleteBitmap* subset_rowset_map) const { |
There was a problem hiding this comment.
warning: method 'subset_ignore' can be made static [readability-convert-member-functions-to-static]
| void DeleteBitmap::subset_ignore(const BitmapKey& start, const BitmapKey& end, | |
| DeleteBitmap* subset_rowset_map) const { | |
| static void DeleteBitmap::subset_ignore(const BitmapKey& start, const BitmapKey& end, | |
| DeleteBitmap* subset_rowset_map) { |
|
run build all |
1 similar comment
|
run build all |
| DeleteBitmap subset_map(tablet_id()); | ||
| input_delete_bitmap.subset({rowset->rowset_id(), seg_id, start_version}, | ||
| {rowset->rowset_id(), seg_id, end_version}, &subset_map); | ||
| input_delete_bitmap.subset_ignore({rowset->rowset_id(), seg_id, start_version}, |
There was a problem hiding this comment.
It can't resolve the compaction issue, since the compaction use merge-on-read process to dedup keys, it can't identify which keys should be ignored.
|
We're closing this PR because it hasn't been updated in a while. |
2 participants
…e table (#21773)
Proposed changes
Issue Number: close #24573
fix data lost bug
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...