Skip to content

[fix](Nereids) init Date/DateV2Literal should check non-zero time fields #24971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 27, 2023
Merged

[fix](Nereids) init Date/DateV2Literal should check non-zero time fields #24971

morrySnow merged 1 commit into from
Sep 27, 2023

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Sep 27, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

morrySnow commented Sep 27, 2023

run buildall

@morrySnow morrySnow requested a review from jackwener September 27, 2023 09:51
starocean999
starocean999 previously approved these changes Sep 27, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 27, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.36 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162096224 Bytes

@morrySnow
Copy link
Contributor Author

morrySnow commented Sep 27, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 27, 2023
@doris-robot
Copy link

doris-robot commented Sep 27, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.66 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162327892 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 63b283a into apache:master Sep 27, 2023
@morrySnow morrySnow deleted the fix_cast_datetime branch September 27, 2023 12:48
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
@morrySnow @vinlee19
[fix](Nereids) init Date/DateV2Literal should check non-zero time fie…
679b888 
…lds (apache#24971)
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 13, 2023
@morrySnow
[fix](Nereids) init Date/DateV2Literal should check non-zero time fields
7b248c2 
check picked from master
PR: apache#24971
commit id: 63b283a
@morrySnow morrySnow mentioned this pull request Oct 13, 2023
Merged
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
@morrySnow
[fix](Nereids) init Date/DateV2Literal should check non-zero time fie…
4b657d5 
…lds (#25402)

check picked from master
PR: #24971
commit id: 63b283a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow @doris-robot @jackwener @starocean999 @xiaokang