-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Opt](performance) refactor and opt time round floor function #25026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| if constexpr (std::is_same_v<DateValueType, VecDateTimeValue>) { | ||
| ts1.reset_zero_by_type(ts2.type()); | ||
| } | ||
| int64_t diff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'diff' is not initialized [cppcoreguidelines-init-variables]
| int64_t diff; | |
| int64_t diff = 0; |
| ts1.reset_zero_by_type(ts2.type()); | ||
| } | ||
| int64_t diff; | ||
| int64_t part; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'part' is not initialized [cppcoreguidelines-init-variables]
| int64_t part; | |
| int64_t part = 0; |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
…#25026) refactor and opt time round floor function
…#25026) refactor and opt time round floor function
Proposed changes
Before:
after:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...