Skip to content

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

Before:

 [testdb]>select hour_floor(`@timestamp`, 4) as t, count() as cnt from httplogs_date group by t order by t limit 10;
+---------------------+--------+
| t                   | cnt    |
+---------------------+--------+
| 1998-05-01 00:00:00 |    324 |
| 1998-05-01 04:00:00 | 174137 |
| 1998-05-01 08:00:00 | 140461 |
| 1998-05-01 12:00:00 | 145945 |
| 1998-05-01 16:00:00 | 213248 |
| 1998-05-01 20:00:00 | 293426 |
| 1998-05-02 00:00:00 | 226038 |
| 1998-05-02 04:00:00 | 119502 |
| 1998-05-02 08:00:00 | 101933 |
| 1998-05-02 12:00:00 |  95275 |
+---------------------+--------+
10 rows in set (2.97 sec)

after:

 [testdb]>select hour_floor(`@timestamp`, 4) as t, count() as cnt from httplogs_date group by t order by t limit 10;
+---------------------+--------+
| t                   | cnt    |
+---------------------+--------+
| 1998-05-01 00:00:00 |    324 |
| 1998-05-01 04:00:00 | 174137 |
| 1998-05-01 08:00:00 | 140461 |
| 1998-05-01 12:00:00 | 145945 |
| 1998-05-01 16:00:00 | 213248 |
| 1998-05-01 20:00:00 | 293426 |
| 1998-05-02 00:00:00 | 226038 |
| 1998-05-02 04:00:00 | 119502 |
| 1998-05-02 08:00:00 | 101933 |
| 1998-05-02 12:00:00 |  95275 |
+---------------------+--------+
10 rows in set (0.67 sec)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

if constexpr (std::is_same_v<DateValueType, VecDateTimeValue>) {
ts1.reset_zero_by_type(ts2.type());
}
int64_t diff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'diff' is not initialized [cppcoreguidelines-init-variables]

Suggested change
int64_t diff;
int64_t diff = 0;

ts1.reset_zero_by_type(ts2.type());
}
int64_t diff;
int64_t part;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'part' is not initialized [cppcoreguidelines-init-variables]

Suggested change
int64_t part;
int64_t part = 0;

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8145/22442)
Line Coverage: 28.44% (65172/229180)
Region Coverage: 27.38% (33754/123293)
Branch Coverage: 24.04% (17214/71602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/05a31933a3c7548db20cc221ddf3c6e93551faec_05a31933a3c7548db20cc221ddf3c6e93551faec/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.52 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162537501 Bytes

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8145/22442)
Line Coverage: 28.43% (65166/229178)
Region Coverage: 27.37% (33746/123293)
Branch Coverage: 24.04% (17215/71602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8a0f4bc7dc9cc0266c85323a95335c5fcc9e0d4e_8a0f4bc7dc9cc0266c85323a95335c5fcc9e0d4e/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162193710 Bytes

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit f8a3034 into apache:master Oct 1, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

PR approved by at least one committer and no changes requested.

vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
HappenLee added a commit to HappenLee/incubator-doris that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. merge_conflict reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants