Skip to content

[Opt](performance) Optimize timeround with minute / second #25073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 5 commits into from
Oct 8, 2023
Merged

[Opt](performance) Optimize timeround with minute / second #25073

HappenLee merged 5 commits into from
Oct 8, 2023

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Oct 7, 2023

Proposed changes

#25026

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mryange
Copy link
Contributor Author

Mryange commented Oct 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 7, 2023

TeamCity be ut coverage result:
Function Coverage: 36.28% (8150/22462)
Line Coverage: 28.41% (65183/229421)
Region Coverage: 27.34% (33751/123429)
Branch Coverage: 24.02% (17216/71680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1755a8080793c71b69c34f566a3cbea53191d43f_1755a8080793c71b69c34f566a3cbea53191d43f/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.48 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162129047 Bytes

@Mryange
Copy link
Contributor Author

Mryange commented Oct 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.18 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162195610 Bytes

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22458)
Line Coverage: 28.41% (65156/229366)
Region Coverage: 27.33% (33759/123512)
Branch Coverage: 24.01% (17204/71646)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4bf6a8dcd3bb36dffa8fb1aece1d7e1a29a4e466_4bf6a8dcd3bb36dffa8fb1aece1d7e1a29a4e466/report/index.html

@HappenLee
Copy link
Contributor

HappenLee commented Oct 8, 2023

Add month opt

@Mryange
Copy link
Contributor Author

Mryange commented Oct 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22458)
Line Coverage: 28.41% (65166/229367)
Region Coverage: 27.34% (33764/123516)
Branch Coverage: 24.02% (17206/71646)
Coverage Report: http://coverage.selectdb-in.cc/coverage/57160fcc7979f0f80b7c9318820a99a48a9cd686_57160fcc7979f0f80b7c9318820a99a48a9cd686/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.36 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162364264 Bytes

HappenLee
HappenLee previously approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR approved by anyone and no changes requested.

@Mryange
Copy link
Contributor Author

Mryange commented Oct 8, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

TeamCity be ut coverage result:
Function Coverage: 36.29% (8151/22458)
Line Coverage: 28.42% (65176/229367)
Region Coverage: 27.34% (33769/123516)
Branch Coverage: 24.02% (17206/71646)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f403ad6b1c7d5098236b57bf9a3fc548d1a31273_f403ad6b1c7d5098236b57bf9a3fc548d1a31273/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.9 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162152763 Bytes

HappenLee
HappenLee approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2023
Gabriel39
Gabriel39 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 451e299 into apache:master Oct 8, 2023
@Mryange Mryange mentioned this pull request Oct 13, 2023
Merged
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
@Mryange
[Opt](performance) Optimize timeround with minute / second #25073 (#2…
d5d6883 
…5404)
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@Mryange
[Opt](performance) Optimize timeround with minute / second (apache#25073
c879ee8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mryange @doris-robot @HappenLee @Gabriel39 @xiaokang