Skip to content

[refactor](Nereids) refactor infer predicate rule to avoid lost cast #25637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 25, 2023
Merged

[refactor](Nereids) refactor infer predicate rule to avoid lost cast #25637

morrySnow merged 1 commit into from
Oct 25, 2023

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Oct 19, 2023 •
edited
Loading

This reverts
"[Fix] (Nereids) Add cast comparison with slot reference when inferring predicate (#21171)"
commit 58f2593.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 19, 2023

run buildall

@morrySnow morrySnow force-pushed the fix_infer_predicate branch from 5a1fe82 to 933f38b Compare October 19, 2023 11:49
@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 19, 2023

run buildall

@morrySnow morrySnow force-pushed the fix_infer_predicate branch from 933f38b to 53b43f9 Compare October 19, 2023 12:14
@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 19, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 19, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.49 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162461956 Bytes

@doris-robot
Copy link

doris-robot commented Oct 19, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.38 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162159158 Bytes

@morrySnow morrySnow force-pushed the fix_infer_predicate branch from 53b43f9 to 3a92f76 Compare October 23, 2023 07:26
@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 23, 2023

run buildall

@morrySnow
[refactor](Nereids) refactor infer predicate rule to avoid lost cast
4bfab85 
This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)"
commit 58f2593.
@morrySnow morrySnow force-pushed the fix_infer_predicate branch from 3a92f76 to 4bfab85 Compare October 24, 2023 05:43
@morrySnow
Copy link
Contributor Author

morrySnow commented Oct 24, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 24, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.61 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162398292 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit ae66464 into apache:master Oct 25, 2023
xiaokang pushed a commit that referenced this pull request Oct 25, 2023
@xiaokang
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (#…
5ca2fc6 
…25637)

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (#21171)"
commit 58f2593.
@morrySnow morrySnow deleted the fix_infer_predicate branch October 26, 2023 02:14
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 26, 2023
@morrySnow
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (a…
6b3dc3f 
…pache#25637)

pick from master
PR: apache#25637
commit id: ae66464

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)"
commit 58f2593.
@morrySnow morrySnow mentioned this pull request Oct 26, 2023
Merged
xiaokang added a commit that referenced this pull request Oct 26, 2023
@xiaokang
Revert "[refactor](Nereids) refactor infer predicate rule to avoid lo…
7cc8ab2 
…st cast (#25637)"

This reverts commit 5ca2fc6, since it's mixed by mistake
@wm1581066 wm1581066 added the usercase Important user case type label label Oct 26, 2023
xiaokang pushed a commit that referenced this pull request Oct 26, 2023
@morrySnow
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (#…
47f95da 
…25637) (#25930)

pick from master
PR: #25637
commit id: ae66464

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (#21171)"
commit 58f2593.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morrySnow
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (a…
c0ec586 
…pache#25637)

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)"
commit 58f2593.
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (a…
83b5ff6 
…pache#25637)

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)"
commit 58f2593.
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@xiaokang
Revert "[refactor](Nereids) refactor infer predicate rule to avoid lo…
8625cb8 
…st cast (apache#25637)"

This reverts commit 5ca2fc6, since it's mixed by mistake
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@morrySnow
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (a…
9bf09cb 
…pache#25637) (apache#25930)

pick from master
PR: apache#25637
commit id: ae66464

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)"
commit 58f2593.
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morrySnow
[refactor](Nereids) refactor infer predicate rule to avoid lost cast (a…
bdf45ad 
…pache#25637)

extract slot and literal in comparison predicate. infer new one by equals predicates.
use TypeCoercion to add cast on new comparison predicate to ensure it is correct.

This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)"
commit 58f2593.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

+1 more reviewer

@keanji-x keanji-x keanji-x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict p0_w reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @doris-robot @keanji-x @starocean999 @xiaokang @wm1581066