[refactor](Nereids) refactor infer predicate rule to avoid lost cast #25930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#25637) pick from master PR: apache#25637 commit id: ae66464 extract slot and literal in comparison predicate. infer new one by equals predicates. use TypeCoercion to add cast on new comparison predicate to ensure it is correct. This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)" commit 58f2593.
Contributor
Author
|
run buildall |
Contributor
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Dec 4, 2023
…pache#25637) (apache#25930) pick from master PR: apache#25637 commit id: ae66464 extract slot and literal in comparison predicate. infer new one by equals predicates. use TypeCoercion to add cast on new comparison predicate to ensure it is correct. This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)" commit 58f2593.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick from master
PR: #25637
commit id: ae66464
extract slot and literal in comparison predicate. infer new one by equals predicates. use TypeCoercion to add cast on new comparison predicate to ensure it is correct.
This reverts "Fix Add cast comparison with slot reference when inferring predicate (#21171)" commit 58f2593.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...