[improvement](tablet clone) furthur repair replicas should be check even if they are versions catchup #26047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick: #25551
If there are loading txns, PR #24845 will try to furthur repair a balance tablet even if their versions are catchup.
Then in scheduler's NEED_FURTHER_REPAIR handler, if no replicas are version fallbehind, the sched ctx will convert to REPLICA_MISSING, then add missing replicas will fail because they don't really miss replicas.
Improvement: for NEED_FURTHER_REPAIR handler, if all the replicas are version catchup, then try to check the txns before further repair txn has finished, if it finished, then mark the replica as further repair finish.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...