[improvement](tablet clone) furthur repair replicas should be check even if they are versions catchup #25551
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| EXPECT_EQ(567, DebugPoints::instance()->get_debug_param_or_default("dbug6", 0)); | ||
| } | ||
|
|
||
| TEST(DebugPointsTest, AddTest) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST(DebugPointsTest, AddTest) { | |
| TEST(DebugPointsTest /*unused*/, AddTest /*unused*/) { |
yujun777
changed the title
|
run buildall |
yujun777
changed the title
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…ven if they are versions catchup (apache#25551)
…ven if they are versions catchup (apache#25551)
…ven if they are versions catchup (apache#25551) (apache#26047)
…ven if they are versions catchup (apache#25551)
5 participants
Proposed changes
If there are loading txns, PR #24845 will try to furthur repair a balance tablet even if their versions are catchup.
Then in scheduler's NEED_FURTHER_REPAIR handler, if no replicas are version fallbehind, the sched ctx will convert to REPLICA_MISSING, then add missing replicas will fail because they don't really miss replicas.
Improvement: for NEED_FURTHER_REPAIR handler, if all the replicas are version catchup, then try to check the txns before further repair txn has finished, if it finished, then mark the replica as further repair finish.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...