[improvement](tablet clone) furthur repair replicas should be check even if they are versions catchup #26046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch 2.0 (apache#25119) This PR is composed of belowing commits which has been merged to Doirs master: * apache#24769 * apache#24672 * apache#24599 * apache#24521 * apache#24405 * apache#24237 * apache#24135 * apache#24074 * apache#24026 * apache#23992 * apache#23978 * apache#23622 * apache#23507 * apache#23354 * apache#23103 * apache#22963 * apache#22896 * apache#22775 * apache#22773
…er to branch 2.0 (apache#25119)" (apache#25403) This reverts commit 4b6ff32. Co-authored-by: AKIHA <cyborgz1999@example.com>
…apache#25098 (apache#25388) Checkpoint thread doesn't update tablet invert index, then in checkpoint thread TabletInvertedIndex.getTablet/getReplica will return null. It may cause some problems. Fix this, let checkpoint thread also update tablet invert index.
…use it at sql-cache. (apache#24491) (apache#25382) Now FE does not record the update time of hms tbl's partitons, so the sql cache may be hit even the hive table's partitions have changed. This pr add a field to record the partition update time, and use it when enable sql-cache. The cache will be missed if any partition has changed at hive side. Use System.currentTimeMillis() but not the event time of hms event because we would better keep the same measurement with the schemaUpdateTime of external table. Add this value to ExternalObjectLog and let slave FEs replay it because it is better to keep the same value with all FEs, so the sql-cache can be hit by the querys through different FEs. Co-authored-by: Xiangyu Wang <dut.xiangyu@gmail.com>
picked from master PR: apache#25153 commit id: d34ab7a
…lds (apache#25402) check picked from master PR: apache#24971 commit id: 63b283a
…re dump in regression test in pipeline query engine (apache#25087) (apache#25411)
…he#25423) this PR apache#25193 have achieve about FE. eg: select count() from lineorder join supplier on lo_partkey < s_suppkey; will have a max filter after build hash table , so could use it to filter probe table data.
…) (apache#25407) it is painful to align node in `explain` and node in `explain physical plan`, since they use two different sets of node IDs. This pr makes 'explain' command use node IDs of their correspond node in 'explain physical plan' (cherry picked from commit ffaa145)
…he segment (apache#25366) (apache#25427) By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment.
…'default' (apache#25331) In previous, if user property `'resource_tags.location'` is not set, the can use Backends with any resource tag. It may confuse that when the DBA set part of Backends to resource group A, then the current existing user should not be able to use this group A util it's `'resource_tags.location'` is set. So in this PR, I change the behavior, that if user property `'resource_tags.location'` is not set, it can only use the Backends with `default` tag.
…5371) Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
fix not display be_port who has ADMIN_PRIV
The offset in map type column is int64, but apache#24810 has put as int32, causing error like:
… compaction policy (apache#25352)
… build in the open phase apache#25920
…st cast (apache#25637)" This reverts commit 5ca2fc6, since it's mixed by mistake
…pache#25637) (apache#25930) pick from master PR: apache#25637 commit id: ae66464 extract slot and literal in comparison predicate. infer new one by equals predicates. use TypeCoercion to add cast on new comparison predicate to ensure it is correct. This reverts "[Fix](Nereids) Add cast comparison with slot reference when inferring predicate (apache#21171)" commit 58f2593.
…on the configuration (apache#25905) docker hive s3 file address is determined based on the configuration custom_settings.env
apache#25945) * [fix](pipeline) exclude some cases which will be include again in the case fix pr Co-authored-by: stephen <hello-stephen@qq.com>
Co-authored-by: AKIHA <cyborgz1999@example.com>
…che#25965) When replaying drop function edit log, the function may not be found, causing runtime exception and FE will fail to start. The function SHOULD be exist, but the reason is still unknown. I change the logic to NOT throw exception if function is not found. This is a workaround to make sure FE can start, and add some log for later debug.
…25994) branch 2.0 does not support complex type in Nereids, disable these cases
Co-authored-by: stephen <hello-stephen@qq.com>
…ven if they are versions catchup (apache#25551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick: #25551
If there are loading txns, PR #24845 will try to furthur repair a balance tablet even if their versions are catchup.
Then in scheduler's NEED_FURTHER_REPAIR handler, if no replicas are version fallbehind, the sched ctx will convert to REPLICA_MISSING, then add missing replicas will fail because they don't really miss replicas.
Improvement: for NEED_FURTHER_REPAIR handler, if all the replicas are version catchup, then try to check the txns before further repair txn has finished, if it finished, then mark the replica as further repair finish.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...