Skip to content

[runtimefilter](nerieds)support Non equal runtime filter for nested loop join #25193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
englefly merged 1 commit into from
Oct 16, 2023
Merged

[runtimefilter](nerieds)support Non equal runtime filter for nested loop join #25193

englefly merged 1 commit into from
Oct 16, 2023

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Oct 9, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly
Copy link
Contributor Author

englefly commented Oct 10, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.57 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162225851 Bytes

@zhangstar333 zhangstar333 mentioned this pull request Oct 11, 2023
Merged
zhangstar333 added a commit that referenced this pull request Oct 12, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (#25290)
013eafc 
this PR #25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
@englefly englefly marked this pull request as ready for review October 12, 2023 09:06
@englefly englefly changed the title Non equal rf [runtimefilter](nerieds)support Non equal runtime filter for nested loop join Oct 12, 2023
@englefly
Copy link
Contributor Author

englefly commented Oct 12, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.69 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162055708 Bytes

zhangstar333
zhangstar333 previously approved these changes Oct 13, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

PR approved by anyone and no changes requested.

zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 13, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
0157a3b 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 13, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
6a40811 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
@englefly
Copy link
Contributor Author

englefly commented Oct 13, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 13, 2023
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
@zhangstar333
[cherry-pick](filter) support only min/max runtime filter in BE (#25423)
9cf7ff6 
this PR #25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
@doris-robot
Copy link

doris-robot commented Oct 13, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.91 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17161862904 Bytes

@englefly
Copy link
Contributor Author

englefly commented Oct 15, 2023

run buildall

1 similar comment
@englefly
Copy link
Contributor Author

englefly commented Oct 15, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 15, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.93 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162135498 Bytes

@englefly
Copy link
Contributor Author

englefly commented Oct 16, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 16, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.96 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162172705 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

PR approved by at least one committer and no changes requested.

@englefly englefly merged commit cf073ec into apache:master Oct 16, 2023
@englefly englefly deleted the non-equal-rf branch October 16, 2023 09:49
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 19, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
b8e2950 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
yiguolei pushed a commit that referenced this pull request Oct 19, 2023
@zhangstar333
[bug](cherry-pick) fix bug of converting outer join probe block to nu…
86b87ee 
…llable (#25626)

* [refactor](join) improve join node output when build table rows is 0 (#23713)

* [Enhancement](filter) support only min/max runtime filter in BE (#25290)

this PR #25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.

* [bug](cherry-pick) fix bug of converting outer join probe block to nullable
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
efad163 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@englefly
[runtimefilter](nerieds)support Non equal runtime filter for nested l…
bb039e7 
…oop join apache#25193
@xiaokang xiaokang mentioned this pull request Nov 3, 2023
Merged
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@englefly
[runtimefilter](nerieds)support Non equal runtime filter for nested l…
497eb79 
…oop join apache#25193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@englefly @doris-robot @starocean999 @zhangstar333