Skip to content

[Enhancement](filter) support only min/max runtime filter in BE #25290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 2 commits into from
Oct 12, 2023
Merged

[Enhancement](filter) support only min/max runtime filter in BE #25290

zhangstar333 merged 2 commits into from
Oct 12, 2023

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Oct 11, 2023 •
edited
Loading

Proposed changes

this PR #25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

clang-tidy review says "All clean, LGTM! 👍"

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Oct 11, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

TeamCity be ut coverage result:
Function Coverage: 36.24% (8149/22487)
Line Coverage: 28.34% (65167/229922)
Region Coverage: 27.27% (33765/123812)
Branch Coverage: 23.96% (17206/71804)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0397ac31af4501d8230fa0fcaf897dff01f07925_0397ac31af4501d8230fa0fcaf897dff01f07925/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.84 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162051221 Bytes

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Oct 11, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

TeamCity be ut coverage result:
Function Coverage: 36.24% (8149/22487)
Line Coverage: 28.34% (65162/229936)
Region Coverage: 27.27% (33766/123840)
Branch Coverage: 23.96% (17208/71812)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0397ac31af4501d8230fa0fcaf897dff01f07925_0397ac31af4501d8230fa0fcaf897dff01f07925/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.67 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17161978679 Bytes

@zhangstar333 zhangstar333 force-pushed the partition_sort_filter branch from 0397ac3 to 49fbb56 Compare October 11, 2023 12:54
@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Oct 11, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

TeamCity be ut coverage result:
Function Coverage: 36.23% (8151/22498)
Line Coverage: 28.35% (65198/230014)
Region Coverage: 27.27% (33785/123906)
Branch Coverage: 23.97% (17219/71828)
Coverage Report: http://coverage.selectdb-in.cc/coverage/49fbb56ac71ef791e2b5070fa46d93bf3aeffb13_49fbb56ac71ef791e2b5070fa46d93bf3aeffb13/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.77 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162339690 Bytes

HappenLee
HappenLee reviewed Oct 12, 2023
View reviewed changes
HappenLee
HappenLee reviewed Oct 12, 2023
View reviewed changes
@zhangstar333 zhangstar333 force-pushed the partition_sort_filter branch from 49fbb56 to b29dd4d Compare October 12, 2023 06:41
@zhangstar333 zhangstar333 force-pushed the partition_sort_filter branch from b29dd4d to 63ced46 Compare October 12, 2023 06:46
@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Oct 12, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.15 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162349083 Bytes

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

TeamCity be ut coverage result:
Function Coverage: 36.24% (8156/22508)
Line Coverage: 28.33% (65301/230469)
Region Coverage: 27.05% (33821/125021)
Branch Coverage: 23.87% (17256/72294)
Coverage Report: http://coverage.selectdb-in.cc/coverage/63ced46bae6d3481c22442e04ff6dcbfe360ad9e_63ced46bae6d3481c22442e04ff6dcbfe360ad9e/report/index.html

HappenLee
HappenLee approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

PR approved by anyone and no changes requested.

@zhangstar333 zhangstar333 merged commit 013eafc into apache:master Oct 12, 2023
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 13, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
0157a3b 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 13, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
6a40811 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
@zhangstar333 zhangstar333 mentioned this pull request Oct 13, 2023
Merged
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 19, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
b8e2950 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
yiguolei pushed a commit that referenced this pull request Oct 19, 2023
@zhangstar333
[bug](cherry-pick) fix bug of converting outer join probe block to nu…
86b87ee 
…llable (#25626)

* [refactor](join) improve join node output when build table rows is 0 (#23713)

* [Enhancement](filter) support only min/max runtime filter in BE (#25290)

this PR #25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.

* [bug](cherry-pick) fix bug of converting outer join probe block to nullable
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@zhangstar333
[Enhancement](filter) support only min/max runtime filter in BE (apac…
efad163 
…he#25290)

this PR apache#25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhangstar333 @doris-robot @BiteTheDDDDt @HappenLee @xiaokang