[bug](fix) show create table show comment error #28346

LemonLiTree · 2023-12-13T09:24:39Z

Proposed changes

Issue Number: close #28284

before

now

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

LemonLiTree · 2023-12-13T09:47:25Z

run buildall

doris-robot · 2023-12-13T10:57:11Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit bea6c394701f2810ee571401a83a95f90a35dd13, data reload: false

run tpch-sf100 query with default conf and session variables
q1	49612	31848	31809	31809
q2	397	137	155	137
q3	1594	1269	1233	1233
q4	1112	892	901	892
q5	3195	3547	3226	3226
q6	274	140	141	140
q7	1000	508	486	486
q8	2144	2208	2187	2187
q9	6920	6867	6897	6867
q10	3230	3308	3283	3283
q11	342	198	210	198
q12	350	205	212	205
q13	4623	3818	4338	3818
q14	426	330	322	322
q15	763	1300	1325	1300
q16	439	385	387	385
q17	1021	548	558	548
q18	7542	7316	7040	7040
q19	1512	1326	1496	1326
q20	548	315	297	297
q21	3071	2657	2678	2657
q22	354	274	285	274
Total cold run time: 90469 ms
Total hot run time: 68630 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	30827	31841	31811	31811
q2	277	162	178	162
q3	3709	3634	3624	3624
q4	2393	2369	2373	2369
q5	5822	5791	5807	5791
q6	242	138	133	133
q7	3053	3394	3369	3369
q8	3529	3539	3519	3519
q9	9239	9209	9136	9136
q10	3987	4073	4050	4050
q11	846	871	1372	871
q12	762	594	585	585
q13	4334	3573	3558	3558
q14	525	458	461	458
q15	1027	1340	1323	1323
q16	512	457	479	457
q17	1881	1860	1871	1860
q18	8943	8358	8330	8330
q19	1758	1790	1770	1770
q20	2990	2577	2779	2577
q21	6529	6191	6128	6128
q22	488	422	413	413
Total cold run time: 93673 ms
Total hot run time: 92294 ms

doris-robot · 2023-12-13T11:01:16Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.86 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17222489958 Bytes

LemonLiTree · 2023-12-14T02:32:57Z

run buildall

doris-robot · 2023-12-14T03:07:10Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit bea6c394701f2810ee571401a83a95f90a35dd13, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4708	4462	4527	4462
q2	376	160	159	159
q3	1463	1282	1257	1257
q4	1112	909	942	909
q5	3201	3179	3183	3179
q6	243	126	131	126
q7	989	496	480	480
q8	2200	2212	2185	2185
q9	6700	6639	6678	6639
q10	3201	3271	3262	3262
q11	332	213	198	198
q12	355	216	210	210
q13	4571	3814	3788	3788
q14	244	218	213	213
q15	565	521	530	521
q16	458	383	386	383
q17	1008	633	571	571
q18	7030	6803	6737	6737
q19	1542	1462	1289	1289
q20	556	301	317	301
q21	3100	2636	2655	2636
q22	361	286	290	286
Total cold run time: 44315 ms
Total hot run time: 39791 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4450	4434	4418	4418
q2	267	168	171	168
q3	3522	3539	3512	3512
q4	2412	2398	2399	2398
q5	5774	5767	5749	5749
q6	236	123	122	122
q7	2365	1883	1886	1883
q8	3520	3523	3532	3523
q9	9074	8997	9007	8997
q10	3916	4010	4021	4010
q11	513	418	400	400
q12	775	603	599	599
q13	4300	3613	3578	3578
q14	293	257	263	257
q15	567	524	519	519
q16	509	443	450	443
q17	1893	1864	1856	1856
q18	8581	8107	7949	7949
q19	1758	1754	1728	1728
q20	2257	1947	1938	1938
q21	6558	6219	6173	6173
q22	508	457	422	422
Total cold run time: 64048 ms
Total hot run time: 60642 ms

doris-robot · 2023-12-14T03:20:11Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.99 seconds
stream load tsv: 590 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17217983537 Bytes

LemonLiTree · 2023-12-14T04:44:16Z

run buildall

doris-robot · 2023-12-14T05:14:22Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit bea6c394701f2810ee571401a83a95f90a35dd13, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4715	4425	4418	4418
q2	367	154	158	154
q3	1467	1251	1242	1242
q4	1114	904	857	857
q5	3159	3217	3193	3193
q6	246	129	126	126
q7	997	489	473	473
q8	2184	2214	2186	2186
q9	6690	6636	6633	6633
q10	3226	3306	3265	3265
q11	315	202	203	202
q12	353	213	210	210
q13	4556	3826	3797	3797
q14	237	213	214	213
q15	574	521	530	521
q16	437	382	388	382
q17	995	613	543	543
q18	7124	6775	6862	6775
q19	1560	1462	1361	1361
q20	551	325	312	312
q21	3053	2642	2652	2642
q22	349	285	285	285
Total cold run time: 44269 ms
Total hot run time: 39790 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4416	4381	4403	4381
q2	273	161	174	161
q3	3486	3488	3494	3488
q4	2404	2398	2382	2382
q5	5712	5713	5720	5713
q6	233	123	121	121
q7	2357	1878	1854	1854
q8	3523	3521	3522	3521
q9	9040	8964	8951	8951
q10	3918	4014	4030	4014
q11	494	388	388	388
q12	758	595	609	595
q13	4293	3553	3578	3553
q14	286	262	254	254
q15	576	527	524	524
q16	504	453	467	453
q17	1904	1877	1832	1832
q18	8598	7997	8072	7997
q19	1752	1779	1758	1758
q20	2248	1940	1951	1940
q21	6474	6107	6121	6107
q22	499	429	424	424
Total cold run time: 63748 ms
Total hot run time: 60411 ms

doris-robot · 2023-12-14T05:27:07Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.48 seconds
stream load tsv: 588 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17221406925 Bytes

LemonLiTree · 2023-12-14T07:54:28Z

run buildall

doris-robot · 2023-12-14T08:33:23Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.18 seconds
stream load tsv: 585 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17219996366 Bytes

doris-robot · 2023-12-14T08:43:05Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit bea6c394701f2810ee571401a83a95f90a35dd13, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4711	4478	4521	4478
q2	375	180	159	159
q3	1458	1271	1180	1180
q4	1114	908	897	897
q5	3174	3162	3170	3162
q6	246	127	126	126
q7	962	485	488	485
q8	2211	2199	2177	2177
q9	6642	6663	6672	6663
q10	3224	3252	3263	3252
q11	326	208	209	208
q12	347	205	206	205
q13	4563	3821	3825	3821
q14	245	217	210	210
q15	566	529	532	529
q16	445	386	397	386
q17	1001	590	554	554
q18	7157	6995	6974	6974
q19	1514	1425	1398	1398
q20	513	313	305	305
q21	3051	2653	2677	2653
q22	347	281	289	281
Total cold run time: 44192 ms
Total hot run time: 40103 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4402	4412	4397	4397
q2	266	162	181	162
q3	3539	3524	3513	3513
q4	2397	2383	2388	2383
q5	5742	5719	5737	5719
q6	241	121	122	121
q7	2388	1844	1868	1844
q8	3524	3530	3522	3522
q9	9028	9002	8970	8970
q10	3907	3990	3994	3990
q11	518	386	387	386
q12	763	593	594	593
q13	4292	3541	3553	3541
q14	283	261	263	261
q15	570	515	523	515
q16	507	461	517	461
q17	1879	1842	1859	1842
q18	8720	8259	8115	8115
q19	1722	1731	1790	1731
q20	2255	1936	1943	1936
q21	6531	6177	6198	6177
q22	523	421	421	421
Total cold run time: 63997 ms
Total hot run time: 60600 ms

xiaokang

LGTM

github-actions · 2023-12-26T04:57:28Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-12-26T04:57:30Z

PR approved by anyone and no changes requested.

morningman

LGTM

Fix two bugs that cause show create table index comment error 1. comment has extra single quotes. 2. quota does not escape in show create table result. ``` COMMENT ''test index" comment'' to COMMENT 'test index\" comment' ``` Refs PR: #6560 #28346

…or (apache#36306) Fix two bugs that cause show create table index comment error 1. comment has extra single quotes. 2. quota does not escape in show create table result. ``` COMMENT ''test index" comment'' to COMMENT 'test index\" comment' ``` Refs PR: apache#6560 apache#28346

LemonLiTree added 3 commits December 13, 2023 17:22

fix

d9702a5

format

2832219

format

bea6c39

xiaokang added usercase Important user case type label dev/2.0.4 labels Dec 13, 2023

xiaokang approved these changes Dec 26, 2023

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 26, 2023

github-actions bot added the reviewed label Dec 26, 2023

morningman approved these changes Dec 27, 2023

View reviewed changes

morningman merged commit d96278a into apache:master Dec 27, 2023

LemonLiTree removed the dev/2.0.4 label Dec 28, 2023

eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 28, 2023

[bug](fix) show create table show comment error (apache#28346)

b01d8c4

hello-stephen pushed a commit to hello-stephen/doris that referenced this pull request Dec 28, 2023

[bug](fix) show create table show comment error (apache#28346)

dbfbdfa

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024

[bug](fix) show create table show comment error (apache#28346)

cdd8014

zgxme mentioned this pull request Jun 14, 2024

[fix](show) show create table show index comment error #36306

Merged

[bug](fix) show create table show comment error #28346

[bug](fix) show create table show comment error #28346

Uh oh!

Conversation

LemonLiTree commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

LemonLiTree commented Dec 13, 2023

Uh oh!

doris-robot commented Dec 13, 2023

Uh oh!

doris-robot commented Dec 13, 2023

Uh oh!

LemonLiTree commented Dec 14, 2023

Uh oh!

doris-robot commented Dec 14, 2023

Uh oh!

doris-robot commented Dec 14, 2023

Uh oh!

LemonLiTree commented Dec 14, 2023

Uh oh!

doris-robot commented Dec 14, 2023

Uh oh!

doris-robot commented Dec 14, 2023

Uh oh!

LemonLiTree commented Dec 14, 2023

Uh oh!

doris-robot commented Dec 14, 2023

Uh oh!

doris-robot commented Dec 14, 2023

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LemonLiTree commented Dec 13, 2023 •

edited

Loading