Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Sep 2, 2021

Proposed changes

Fix bug that if a tablet belongs to a colocation table, and one of its
replica is in DECOMMISSION state. This tablet can not be repaired.

Also fix a bug that quota does not escape in show create table result.

COMMENT "a"bc" to COMMENT "a\"bc"

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Bug] Replica state is in DECOMMISSION forever #6561) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Fix bug that if a tablet belongs to a colocation table, and one of its
replica is in DECOMMISSION state. This tablet can not be repaired.
@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/colocated Issues or PRs related to colocated tables area/tablet-scheduler labels Sep 2, 2021
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

PR approved by anyone and no changes requested.

@morningman morningman merged commit bf6d043 into apache:master Sep 7, 2021
starocean999 pushed a commit that referenced this pull request Jun 25, 2024
Fix two bugs that cause show create table index comment error

1. comment has extra single quotes.
2. quota does not escape in show create table result.
```
COMMENT ''test index" comment'' to COMMENT 'test index\" comment'
```

Refs PR:
#6560
#28346
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
Fix two bugs that cause show create table index comment error

1. comment has extra single quotes.
2. quota does not escape in show create table result.
```
COMMENT ''test index" comment'' to COMMENT 'test index\" comment'
```

Refs PR:
#6560
#28346
zgxme pushed a commit to zgxme/doris that referenced this pull request Jun 30, 2024
…or (apache#36306)

Fix two bugs that cause show create table index comment error

1. comment has extra single quotes.
2. quota does not escape in show create table result.
```
COMMENT ''test index" comment'' to COMMENT 'test index\" comment'
```

Refs PR:
apache#6560
apache#28346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/colocated Issues or PRs related to colocated tables area/tablet-scheduler kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Replica state is in DECOMMISSION forever

2 participants