Skip to content

Conversation

@morningman
Copy link
Contributor

Proposed changes

Introduced from #27861

The dbName saved in CreateTableInfo has default_cluster prefix, it should be removed.

Also modify the entry of getDb in internal catalog. This is a cover-up plan in case there may still
db name exist with default_cluster prefix.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman
Copy link
Contributor Author

run buildall

@morningman morningman added the not-merge/2.0 do not merge into 2.0 branch label Dec 17, 2023
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

run beut

@morningman
Copy link
Contributor Author

run clickbench

@morningman morningman merged commit b06f3ed into apache:master Dec 17, 2023
@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit cefd9b0b43cbbc2a3ae80e5fcc4d28ee87d216c4, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4710	4450	4477	4450
q2	359	165	161	161
q3	1473	1263	1257	1257
q4	1123	951	956	951
q5	3132	3157	3132	3132
q6	243	126	126	126
q7	998	493	500	493
q8	2261	2232	2211	2211
q9	6729	6705	6720	6705
q10	3223	3291	3269	3269
q11	317	202	207	202
q12	359	219	208	208
q13	4546	3831	3801	3801
q14	241	218	212	212
q15	575	520	527	520
q16	437	393	383	383
q17	1032	647	582	582
q18	7207	6998	6978	6978
q19	1539	1456	1390	1390
q20	530	308	299	299
q21	3063	2664	2681	2664
q22	348	283	279	279
Total cold run time: 44445 ms
Total hot run time: 40273 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4392	4368	4402	4368
q2	269	164	169	164
q3	3550	3530	3533	3530
q4	2389	2384	2379	2379
q5	5734	5726	5727	5726
q6	241	123	122	122
q7	2401	1874	1871	1871
q8	3533	3549	3526	3526
q9	9041	8975	8954	8954
q10	3911	3995	4012	3995
q11	498	385	379	379
q12	764	601	590	590
q13	4270	3612	3571	3571
q14	295	250	253	250
q15	579	520	526	520
q16	503	452	469	452
q17	1869	1868	1882	1868
q18	8640	8278	8158	8158
q19	1748	1762	1785	1762
q20	2245	1949	1935	1935
q21	6542	6184	6206	6184
q22	507	429	416	416
Total cold run time: 63921 ms
Total hot run time: 60720 ms

hello-stephen pushed a commit to hello-stephen/doris that referenced this pull request Dec 28, 2023
…pache#28532)

Introduced from apache#27861

The `dbName` saved in `CreateTableInfo` has `default_cluster` prefix, it should be removed.

Also modify the entry of `getDb` in internal catalog. This is a cover-up plan in case there may still 
db name exist with `default_cluster` prefix.
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
…pache#28532)

Introduced from apache#27861

The `dbName` saved in `CreateTableInfo` has `default_cluster` prefix, it should be removed.

Also modify the entry of `getDb` in internal catalog. This is a cover-up plan in case there may still 
db name exist with `default_cluster` prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. meta-change not-merge/2.0 do not merge into 2.0 branch reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants