[refactor](cluster)(step-4) remove cluster related to Database #27861
Conversation
morningman
force-pushed
the
db_cluster
branch
from
eb2d47e to
cef2552
Compare
morningman
changed the title
morningman
force-pushed
the
db_cluster
branch
from
cef2552 to
80735ad
Compare
|
run buildall |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morningman
force-pushed
the
db_cluster
branch
from
b897947 to
484d4cd
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
force-pushed
the
db_cluster
branch
2 times, most recently
from
43f7c27 to
cec8613
Compare
|
run buildall |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
force-pushed
the
db_cluster
branch
from
cb0a501 to
328fc2e
Compare
|
run buildall |
morningman
force-pushed
the
db_cluster
branch
from
328fc2e to
3b570c5
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
force-pushed
the
db_cluster
branch
2 times, most recently
from
68f8ad4 to
92c7515
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
force-pushed
the
db_cluster
branch
from
2e86648 to
200eb10
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
…e#27861) Issue Number: apache#19897 Remove `default_cluster` prefix related to database. When upgrading, all prefix will be removed.
…pache#28532) Introduced from apache#27861 The `dbName` saved in `CreateTableInfo` has `default_cluster` prefix, it should be removed. Also modify the entry of `getDb` in internal catalog. This is a cover-up plan in case there may still db name exist with `default_cluster` prefix.
…e#27861) Issue Number: apache#19897 Remove `default_cluster` prefix related to database. When upgrading, all prefix will be removed.
…pache#28532) Introduced from apache#27861 The `dbName` saved in `CreateTableInfo` has `default_cluster` prefix, it should be removed. Also modify the entry of `getDb` in internal catalog. This is a cover-up plan in case there may still db name exist with `default_cluster` prefix.
…8199) Use the sql to query routine load records: ``` show routine load for db.job1\G ``` return all routine load job in the db: ``` 10 rows in set (0.02 sec) ``` why the bug happen is there is no correct assignment when analyze the sql: ``` if (Strings.isNullOrEmpty(dbName)) { dbFullName = analyzer.getContext().getDatabase(); if (Strings.isNullOrEmpty(dbFullName)) { ErrorReport.reportAnalysisException(ErrorCode.ERR_NO_DB_ERROR); } } ``` dbFullName will always null if dbName is not null or empty. The bug is introduce by: #27861
…8199) Use the sql to query routine load records: ``` show routine load for db.job1\G ``` return all routine load job in the db: ``` 10 rows in set (0.02 sec) ``` why the bug happen is there is no correct assignment when analyze the sql: ``` if (Strings.isNullOrEmpty(dbName)) { dbFullName = analyzer.getContext().getDatabase(); if (Strings.isNullOrEmpty(dbFullName)) { ErrorReport.reportAnalysisException(ErrorCode.ERR_NO_DB_ERROR); } } ``` dbFullName will always null if dbName is not null or empty. The bug is introduce by: #27861
fix - when label contains dbName, will loss intro by apache#27861 - show routine load for xxx.yyy can export authentication error intro by apache#33347 Note: Cases will be added uniformly in other PRs
4 participants
Proposed changes
Issue Number: #19897
Remove
default_clusterprefix related to database.When upgrading, all prefix will be removed.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...