[fix](auth)fix missing authentication #33347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 38856 ms |
TPC-DS: Total hot run time: 183609 ms |
ClickBench: Total hot run time: 30.29 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
BePPPower
approved these changes
Apr 15, 2024
morningman
approved these changes
Apr 15, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
deardeng
added a commit
to deardeng/incubator-doris
that referenced
this pull request
Apr 16, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 17, 2024
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Apr 22, 2024
- Modified permission prompt information: added display of which permission items are required to perform the current operation, removed prompt information for "current user" and "IP" - `AdminCopyTablet` use `PrivPredicate.ADMIN` check auth, before is `PrivPredicate.OPERATOR` - `row policy` use `PrivPredicate.GRANT` - `storage policy` keep `PrivPredicate.ADMIN` unchanged - `create/alter view` need has `select_priv` on base table - `cancel alter system` need `PrivPredicate.OPERATOR` - `drop sync materialized view` need `alter_priv` before is `drop_priv` - `SetLdapPassVar` need `admin_priv` before only `root/admin` can do - `ShowCatalogRecycleBin` use `PrivPredicate.ADMIN` - `ShowCreateRepository` use `PrivPredicate.ADMIN` - `ShowDataRepository` use `PrivPredicate.ADMIN` - `ShowEncryptKey` use `PrivPredicate.ADMIN` - `ShowPlugins` use `PrivPredicate.ADMIN` - `ShowRepositories` use `PrivPredicate.ADMIN` - `ShowSnapshot` use `PrivPredicate.ADMIN` - `ShowTabletsBelong` use `PrivPredicate.ADMIN` - `ShowTranscation` use `PrivPredicate.ADMIN` - `show create db` use `show` instead of `PrivPredicate.ALTER_CREATE_DROP` - `cancel export`,if table size >1,use `db.PrivPredicate.SELECT`,else use `table.PrivPredicate.SELECT` - `show stream load`,`table.PrivPredicate.LOAD` - `show load`,if table size >1, use `db.PrivPredicate.LOAD`,else use `table.PrivPredicate.LOAD`
morningman
added a commit
that referenced
this pull request
Apr 22, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
morrySnow
pushed a commit
that referenced
this pull request
Jul 30, 2024
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 9, 2024
fix - when label contains dbName, will loss intro by apache#27861 - show routine load for xxx.yyy can export authentication error intro by apache#33347 Note: Cases will be added uniformly in other PRs
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
AdminCopyTabletusePrivPredicate.ADMINcheck auth, before isPrivPredicate.OPERATORrow policyusePrivPredicate.GRANTstorage policykeepPrivPredicate.ADMINunchangedcreate/alter viewneed hasselect_privon base tablecancel alter systemneedPrivPredicate.OPERATORdrop sync materialized viewneedalter_privbefore isdrop_privSetLdapPassVarneedadmin_privbefore onlyroot/admincan doShowCatalogRecycleBinusePrivPredicate.ADMINShowCreateRepositoryusePrivPredicate.ADMINShowDataRepositoryusePrivPredicate.ADMINShowEncryptKeyusePrivPredicate.ADMINShowPluginsusePrivPredicate.ADMINShowRepositoriesusePrivPredicate.ADMINShowSnapshotusePrivPredicate.ADMINShowTabletsBelongusePrivPredicate.ADMINShowTranscationusePrivPredicate.ADMINshow create dbuseshowinstead ofPrivPredicate.ALTER_CREATE_DROPcancel export,if table size >1,usedb.PrivPredicate.SELECT,else usetable.PrivPredicate.SELECTshow stream load,table.PrivPredicate.LOADshow load,if table size >1,usedb.PrivPredicate.LOAD,else usetable.PrivPredicate.LOADFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...