[fix](udf) fix java-udf coredump as get env return nullptr #30986

zhangstar333 · 2024-02-08T06:08:41Z

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-02-08T06:08:45Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

zhangstar333 · 2024-02-08T06:08:51Z

run buildall

be/src/runtime/fold_constant_executor.cpp

github-actions · 2024-02-08T06:18:53Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-02-08T06:36:51Z

clang-tidy review says "All clean, LGTM! 👍"

zhangstar333 · 2024-02-08T06:38:19Z

run buildall

doris-robot · 2024-02-08T07:01:29Z

TeamCity be ut coverage result:
Function Coverage: 35.84% (8556/23874)
Line Coverage: 27.78% (69461/250035)
Region Coverage: 26.92% (36040/133894)
Branch Coverage: 23.70% (18432/77756)
Coverage Report: http://coverage.selectdb-in.cc/coverage/78c2aee09832c795c3ecc41e9f4e62abbcabd100_78c2aee09832c795c3ecc41e9f4e62abbcabd100/report/index.html

doris-robot · 2024-02-08T07:18:39Z

TPC-H: Total hot run time: 41352 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78c2aee09832c795c3ecc41e9f4e62abbcabd100, data reload: false

------ Round 1 ----------------------------------
q1	17685	4971	4862	4862
q2	2043	138	133	133
q3	10586	1033	1008	1008
q4	4656	941	967	941
q5	7687	3236	3274	3236
q6	201	140	139	139
q7	1283	765	745	745
q8	9221	2092	2074	2074
q9	7595	6690	6668	6668
q10	8297	2630	2631	2630
q11	417	223	223	223
q12	803	327	328	327
q13	18000	3677	3667	3667
q14	304	258	260	258
q15	593	510	493	493
q16	480	398	418	398
q17	929	852	827	827
q18	7546	6690	6584	6584
q19	1554	1487	1499	1487
q20	610	356	339	339
q21	7126	3986	4000	3986
q22	879	350	327	327
Total cold run time: 108495 ms
Total hot run time: 41352 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4926	4880	4832	4832
q2	292	182	184	182
q3	3579	3596	3582	3582
q4	2539	2506	2506	2506
q5	5743	5728	5714	5714
q6	212	130	127	127
q7	2219	1656	1710	1656
q8	3011	3091	3118	3091
q9	8671	8707	8678	8678
q10	6774	4240	4206	4206
q11	508	392	365	365
q12	761	531	524	524
q13	4442	3395	3409	3395
q14	269	236	222	222
q15	634	505	502	502
q16	479	457	425	425
q17	1673	1605	1590	1590
q18	8386	7630	7496	7496
q19	1632	1641	1635	1635
q20	2103	1823	1832	1823
q21	6516	6107	6124	6107
q22	574	503	522	503
Total cold run time: 65943 ms
Total hot run time: 59161 ms

doris-robot · 2024-02-08T07:30:07Z

TPC-DS: Total hot run time: 180770 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78c2aee09832c795c3ecc41e9f4e62abbcabd100, data reload: false

query1	941	355	351	351
query2	6530	1782	1874	1782
query3	6693	206	206	206
query4	24475	22446	22469	22446
query5	4294	465	455	455
query6	257	176	167	167
query7	4601	293	288	288
query8	243	197	198	197
query9	8406	2889	2875	2875
query10	408	218	235	218
query11	16228	15598	15546	15546
query12	141	86	83	83
query13	1710	437	421	421
query14	9109	7828	7717	7717
query15	213	190	192	190
query16	7381	249	244	244
query17	1428	561	535	535
query18	1943	272	256	256
query19	193	146	155	146
query20	86	81	84	81
query21	185	120	122	120
query22	4697	4771	4834	4771
query23	32432	31598	31566	31566
query24	12820	3415	3503	3415
query25	650	367	366	366
query26	1882	152	156	152
query27	3065	304	309	304
query28	6616	1845	1835	1835
query29	1213	621	624	621
query30	284	136	146	136
query31	942	755	777	755
query32	96	62	56	56
query33	727	236	226	226
query34	1060	483	492	483
query35	940	822	826	822
query36	990	914	930	914
query37	179	64	63	63
query38	3413	3298	3360	3298
query39	1366	1329	1336	1329
query40	287	105	104	104
query41	37	36	34	34
query42	106	97	100	97
query43	507	440	438	438
query44	1088	696	706	696
query45	200	186	176	176
query46	1042	760	737	737
query47	1608	1548	1585	1548
query48	421	341	350	341
query49	1215	311	299	299
query50	778	375	388	375
query51	5311	5149	5134	5134
query52	108	94	93	93
query53	396	302	304	302
query54	282	226	228	226
query55	86	83	75	75
query56	222	196	211	196
query57	1028	915	949	915
query58	230	198	202	198
query59	2248	2149	2233	2149
query60	246	228	224	224
query61	83	85	85	85
query62	580	364	384	364
query63	341	295	284	284
query64	6381	3100	3131	3100
query65	3270	3257	3240	3240
query66	1330	340	320	320
query67	14470	14284	14199	14199
query68	5140	529	551	529
query69	530	356	353	353
query70	1254	1242	1259	1242
query71	425	257	265	257
query72	6408	2776	2632	2632
query73	712	302	310	302
query74	7183	6725	6703	6703
query75	3184	2537	2530	2530
query76	3256	1104	1188	1104
query77	350	245	235	235
query78	9488	8778	8738	8738
query79	945	493	516	493
query80	518	353	347	347
query81	439	211	211	211
query82	165	84	82	82
query83	142	118	123	118
query84	222	76	78	76
query85	1038	343	352	343
query86	292	299	301	299
query87	3562	3417	3365	3365
query88	2710	2285	2280	2280
query89	447	359	360	359
query90	1938	171	167	167
query91	156	126	127	126
query92	53	48	51	48
query93	976	469	499	469
query94	1113	185	184	184
query95	8599	8369	375	375
query96	577	261	266	261
query97	4449	4241	4294	4241
query98	234	207	195	195
query99	1076	758	721	721
Total cold run time: 280319 ms
Total hot run time: 180770 ms

doris-robot · 2024-02-08T07:35:35Z

ClickBench: Total hot run time: 30.42 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78c2aee09832c795c3ecc41e9f4e62abbcabd100, data reload: false

query1	0.02	0.03	0.02
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.66	0.08	0.08
query5	0.48	0.47	0.47
query6	1.36	0.62	0.63
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.54	0.44	0.46
query10	0.48	0.48	0.48
query11	0.12	0.09	0.10
query12	0.12	0.10	0.10
query13	0.59	0.59	0.60
query14	0.76	0.77	0.79
query15	0.81	0.80	0.79
query16	0.33	0.34	0.32
query17	0.88	0.86	0.90
query18	0.18	0.18	0.17
query19	1.75	1.67	1.66
query20	0.02	0.01	0.01
query21	15.41	0.64	0.58
query22	2.72	4.89	1.87
query23	17.80	1.18	0.95
query24	2.00	0.36	0.55
query25	0.63	0.09	0.04
query26	0.17	0.14	0.15
query27	0.05	0.05	0.05
query28	12.01	0.81	0.80
query29	12.55	3.33	3.32
query30	0.50	0.48	0.50
query31	2.77	0.35	0.37
query32	3.34	0.48	0.48
query33	3.12	3.10	3.22
query34	17.17	4.55	4.54
query35	4.57	4.54	4.54
query36	1.08	1.00	0.96
query37	0.07	0.05	0.05
query38	0.04	0.02	0.03
query39	0.02	0.01	0.02
query40	0.20	0.15	0.14
query41	0.07	0.02	0.01
query42	0.02	0.01	0.01
query43	0.02	0.02	0.02
Total cold run time: 106.77 s
Total hot run time: 30.42 s

doris-robot · 2024-02-08T07:38:42Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 78c2aee09832c795c3ecc41e9f4e62abbcabd100 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       14.0 seconds inserted 10000000 Rows, about 714K ops/s

github-actions · 2024-02-18T09:02:04Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-02-18T09:02:07Z

PR approved by anyone and no changes requested.

be/src/runtime/fold_constant_executor.cpp

github-actions · 2024-02-19T02:45:18Z

clang-tidy review says "All clean, LGTM! 👍"

zhangstar333 · 2024-02-19T02:46:32Z

run buildall

doris-robot · 2024-02-19T03:18:18Z

TeamCity be ut coverage result:
Function Coverage: 35.78% (8561/23929)
Line Coverage: 27.74% (69447/250381)
Region Coverage: 26.86% (36040/134162)
Branch Coverage: 23.67% (18430/77876)
Coverage Report: http://coverage.selectdb-in.cc/coverage/73cd21fb2cdc460bec4fc9d954630bb0fd6e9e3b_73cd21fb2cdc460bec4fc9d954630bb0fd6e9e3b/report/index.html

HappenLee

LGTM

github-actions · 2024-02-19T09:06:13Z

PR approved by at least one committer and no changes requested.

)

…30986) (#31118) * [fix](udf) fix java-udf coredump as get env return nullptr (#30986) * update log

…pache#30986) (apache#31118) * [fix](udf) fix java-udf coredump as get env return nullptr (apache#30986) * update log

[fix](udf) fix java-udf get env return nullptr

f306baf

yiguolei reviewed Feb 8, 2024

View reviewed changes

be/src/runtime/fold_constant_executor.cpp Outdated Show resolved Hide resolved

update log

78c2aee

Gabriel39 previously approved these changes Feb 18, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 18, 2024

github-actions bot added the reviewed label Feb 18, 2024

xiaokang added p0_c dev/2.0.5 labels Feb 18, 2024

HappenLee reviewed Feb 19, 2024

View reviewed changes

be/src/runtime/fold_constant_executor.cpp Show resolved Hide resolved

update log

73cd21f

zhangstar333 dismissed Gabriel39’s stale review via 73cd21f February 19, 2024 02:34

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 19, 2024

HappenLee approved these changes Feb 19, 2024

View reviewed changes

Gabriel39 approved these changes Feb 19, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 19, 2024

yiguolei merged commit 7811bae into apache:master Feb 19, 2024

yiguolei pushed a commit that referenced this pull request Feb 19, 2024

[fix](udf) fix java-udf coredump as get env return nullptr (#30986)

8a3e664

zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Feb 19, 2024

[fix](udf) fix java-udf coredump as get env return nullptr (apache#30986

a4e53c1

)

zhangstar333 mentioned this pull request Feb 19, 2024

[cherry-pick](udf) fix java-udf coredump as get env return nullptr (#30986) #31118

Merged

yiguolei pushed a commit that referenced this pull request Feb 19, 2024

[cherry-pick](udf) fix java-udf coredump as get env return nullptr (#…

8a625f4

…30986) (#31118) * [fix](udf) fix java-udf coredump as get env return nullptr (#30986) * update log

yiguolei added dev/2.0.5-merged and removed dev/2.0.5 labels Feb 19, 2024

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024

[cherry-pick](udf) fix java-udf coredump as get env return nullptr (a…

887da5f

…pache#30986) (apache#31118) * [fix](udf) fix java-udf coredump as get env return nullptr (apache#30986) * update log

[fix](udf) fix java-udf coredump as get env return nullptr #30986

[fix](udf) fix java-udf coredump as get env return nullptr #30986

Uh oh!

Conversation

zhangstar333 commented Feb 8, 2024

Proposed changes

Further comments

Uh oh!

doris-robot commented Feb 8, 2024

Uh oh!

zhangstar333 commented Feb 8, 2024

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2024

Uh oh!

github-actions bot commented Feb 8, 2024

Uh oh!

zhangstar333 commented Feb 8, 2024

Uh oh!

doris-robot commented Feb 8, 2024

Uh oh!

doris-robot commented Feb 8, 2024

Uh oh!

doris-robot commented Feb 8, 2024

Uh oh!

doris-robot commented Feb 8, 2024

Uh oh!

doris-robot commented Feb 8, 2024

Uh oh!

github-actions bot commented Feb 18, 2024

Uh oh!

github-actions bot commented Feb 18, 2024

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2024

Uh oh!

zhangstar333 commented Feb 19, 2024

Uh oh!

doris-robot commented Feb 19, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants