Skip to content

[cherry-pick](udf) fix java-udf coredump as get env return nullptr (#30986) #31118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Feb 19, 2024
Merged

[cherry-pick](udf) fix java-udf coredump as get env return nullptr (#30986) #31118

yiguolei merged 2 commits into from
Feb 19, 2024

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Feb 19, 2024

Proposed changes

cherry-pick from master #30986

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Feb 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Feb 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Feb 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Feb 19, 2024

TPC-H: Total hot run time: 49902 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 177035e7148c40cd93a89f22970723164d9c7359, data reload: false

------ Round 1 ----------------------------------
q1	17666	4457	4355	4355
q2	2048	163	146	146
q3	10354	1910	1904	1904
q4	10116	1277	1334	1277
q5	8747	3943	4034	3943
q6	231	124	125	124
q7	2051	1624	1616	1616
q8	9322	2739	2739	2739
q9	10894	10395	10327	10327
q10	8696	3529	3497	3497
q11	422	248	238	238
q12	467	299	304	299
q13	18353	3964	4065	3964
q14	347	321	329	321
q15	511	458	453	453
q16	710	589	594	589
q17	1129	970	943	943
q18	7338	6904	6808	6808
q19	1696	1567	1544	1544
q20	514	305	300	300
q21	4484	4172	4115	4115
q22	493	400	400	400
Total cold run time: 116589 ms
Total hot run time: 49902 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4321	4308	4287	4287
q2	316	216	226	216
q3	4162	4159	4153	4153
q4	2755	2755	2754	2754
q5	7292	7232	7233	7232
q6	237	121	118	118
q7	3224	2914	2893	2893
q8	4387	4512	4481	4481
q9	17110	17045	16945	16945
q10	4227	4268	4264	4264
q11	762	689	672	672
q12	1023	857	858	857
q13	6850	3706	3746	3706
q14	461	420	429	420
q15	489	454	455	454
q16	779	716	706	706
q17	3827	3842	3856	3842
q18	8935	8729	8767	8729
q19	1700	1719	1685	1685
q20	2361	2134	2109	2109
q21	8448	8536	8621	8536
q22	1040	958	999	958
Total cold run time: 84706 ms
Total hot run time: 80017 ms

@doris-robot
Copy link

doris-robot commented Feb 19, 2024

TeamCity be ut coverage result:
Function Coverage: 37.82% (8035/21247)
Line Coverage: 29.49% (65504/222159)
Region Coverage: 28.96% (33704/116400)
Branch Coverage: 24.81% (17299/69724)
Coverage Report: http://coverage.selectdb-in.cc/coverage/177035e7148c40cd93a89f22970723164d9c7359_177035e7148c40cd93a89f22970723164d9c7359/report/index.html

@doris-robot
Copy link

doris-robot commented Feb 19, 2024

TPC-DS: Total hot run time: 234857 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 177035e7148c40cd93a89f22970723164d9c7359, data reload: false

query1	949	392	380	380
query2	6515	2254	2017	2017
query3	6911	204	210	204
query4	20357	17893	17962	17893
query5	19718	6525	6533	6525
query6	297	213	233	213
query7	4146	295	292	292
query8	255	238	239	238
query9	3158	2773	2658	2658
query10	432	306	295	295
query11	11388	10682	10747	10682
query12	118	77	73	73
query13	5578	653	633	633
query14	17832	13223	13720	13223
query15	360	238	232	232
query16	6436	268	258	258
query17	1724	1471	860	860
query18	2307	406	409	406
query19	197	139	147	139
query20	85	78	74	74
query21	187	93	90	90
query22	5325	5008	5029	5008
query23	32645	31951	31903	31903
query24	6930	6472	6484	6472
query25	523	436	392	392
query26	536	160	155	155
query27	1884	293	295	293
query28	6064	2255	2210	2210
query29	2810	2801	2825	2801
query30	233	162	160	160
query31	923	759	718	718
query32	62	59	58	58
query33	382	243	239	239
query34	848	448	476	448
query35	1101	928	920	920
query36	1656	1529	1416	1416
query37	92	61	57	57
query38	3106	2963	2941	2941
query39	1363	1334	1338	1334
query40	195	95	93	93
query41	35	35	31	31
query42	86	84	86	84
query43	778	623	616	616
query44	1138	708	714	708
query45	235	218	222	218
query46	1235	943	957	943
query47	1983	1715	1673	1673
query48	980	669	652	652
query49	632	360	367	360
query50	841	588	625	588
query51	5534	5430	5466	5430
query52	93	76	67	67
query53	434	308	315	308
query54	2634	2442	2459	2442
query55	92	74	83	74
query56	212	207	198	198
query57	1131	1093	1161	1093
query58	212	205	193	193
query59	3314	3391	3114	3114
query60	217	185	184	184
query61	82	83	76	76
query62	725	439	518	439
query63	473	329	328	328
query64	2587	1485	1333	1333
query65	3595	3551	3558	3551
query66	781	371	360	360
query67	16212	15396	15275	15275
query68	8259	680	676	676
query69	559	344	362	344
query70	1807	1946	1850	1850
query71	406	297	310	297
query72	6460	3417	3387	3387
query73	730	325	320	320
query74	6312	5874	5848	5848
query75	4507	3712	3677	3677
query76	4621	1107	1150	1107
query77	591	248	242	242
query78	31220	52510	44203	44203
query79	15709	664	650	650
query80	5060	374	376	374
query81	576	233	230	230
query82	806	94	96	94
query83	412	139	133	133
query84	255	69	68	68
query85	2649	279	265	265
query86	493	346	362	346
query87	3205	3028	2989	2989
query88	6301	2321	2308	2308
query89	397	284	276	276
query90	2497	200	213	200
query91	147	112	115	112
query92	60	49	51	49
query93	5053	585	572	572
query94	1847	204	206	204
query95	1111	1070	1050	1050
query96	649	329	334	329
query97	6496	6322	6465	6322
query98	193	178	174	174
query99	3923	890	820	820
Total cold run time: 345210 ms
Total hot run time: 234857 ms

@doris-robot
Copy link

doris-robot commented Feb 19, 2024

ClickBench: Total hot run time: 30.55 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 177035e7148c40cd93a89f22970723164d9c7359, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.02	0.02
query3	0.24	0.05	0.05
query4	1.81	0.07	0.06
query5	0.53	0.52	0.53
query6	1.24	0.62	0.61
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.52	0.49	0.48
query10	0.54	0.57	0.53
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.63	0.62	0.61
query14	0.78	0.77	0.81
query15	0.79	0.76	0.77
query16	0.35	0.39	0.37
query17	1.01	1.01	1.03
query18	0.22	0.27	0.24
query19	1.96	1.81	1.85
query20	0.02	0.01	0.01
query21	15.47	0.56	0.55
query22	1.98	2.41	1.49
query23	17.34	0.98	0.84
query24	7.45	1.62	0.88
query25	1.46	0.12	0.11
query26	0.29	0.14	0.13
query27	0.11	0.11	0.10
query28	6.13	0.75	0.77
query29	12.78	2.34	2.36
query30	0.61	0.52	0.51
query31	2.80	0.36	0.37
query32	3.41	0.50	0.49
query33	3.03	3.10	3.06
query34	15.27	4.79	4.81
query35	4.88	4.85	4.83
query36	1.05	1.00	1.02
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.13	0.14
query41	0.06	0.01	0.01
query42	0.02	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 105.48 s
Total hot run time: 30.55 s

@doris-robot
Copy link

doris-robot commented Feb 19, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 177035e7148c40cd93a89f22970723164d9c7359 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.1 seconds inserted 10000000 Rows, about 473K ops/s

@yiguolei yiguolei merged commit 8a625f4 into apache:branch-2.0 Feb 19, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zhangstar333
[cherry-pick](udf) fix java-udf coredump as get env return nullptr (a…
887da5f 
…pache#30986) (apache#31118)

* [fix](udf) fix java-udf coredump as get env return nullptr (apache#30986)

* update log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/nereids

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangstar333 @doris-robot @yiguolei