-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[bugfix](export command) Export exceptions when use legacy optimizer #31020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Member
Author
|
run buildall |
1 similar comment
Member
Author
|
run buildall |
TPC-H: Total hot run time: 41118 ms |
TPC-DS: Total hot run time: 180804 ms |
ClickBench: Total hot run time: 30.8 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 41942 ms |
TPC-DS: Total hot run time: 184554 ms |
ClickBench: Total hot run time: 31.5 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Member
Author
|
run feut |
morrySnow
approved these changes
Feb 18, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Feb 18, 2024
yiguolei
pushed a commit
that referenced
this pull request
Feb 18, 2024
mymeiyi
pushed a commit
to mymeiyi/doris
that referenced
this pull request
Feb 19, 2024
morningman
pushed a commit
that referenced
this pull request
May 14, 2024
1. Forbid rollback to the old optimizer in `Export` task. Since originStmt is empty, reverting to the old optimizer when the new optimizer is enabled is meaningless. 2. Display `parallelism` in 'show export'. 3. Create an initial Map for resultAttachedInfo to avoid NullPointerException. 4. Remove the originStmt added in this PR #31020, because the `Export` statement is underlying the Outfile statement, it cannot be treated as `OriginStmt`.
yiguolei
pushed a commit
that referenced
this pull request
May 15, 2024
1. Forbid rollback to the old optimizer in `Export` task. Since originStmt is empty, reverting to the old optimizer when the new optimizer is enabled is meaningless. 2. Display `parallelism` in 'show export'. 3. Create an initial Map for resultAttachedInfo to avoid NullPointerException. 4. Remove the originStmt added in this PR #31020, because the `Export` statement is underlying the Outfile statement, it cannot be treated as `OriginStmt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #30645
Exception information will not be thrown when exporting exceptions, theck this #30645
The actual exception is
Exporting results to local disk is not allowed.To enable this feature, you need to add enable_outfile_to_local=true in fe.conf and restart FEFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...