-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Export) fix some issues of Export #34345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
2cf4910 to
69d6082
Compare
|
run buildall |
TPC-H: Total hot run time: 41319 ms |
TPC-DS: Total hot run time: 186701 ms |
69d6082 to
b89d0cf
Compare
|
run buildall |
1 similar comment
|
run buildall |
b89d0cf to
a4e317f
Compare
|
run buildall |
TPC-H: Total hot run time: 40939 ms |
TPC-DS: Total hot run time: 187156 ms |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Forbid rollback to the old optimizer in `Export` task. Since originStmt is empty, reverting to the old optimizer when the new optimizer is enabled is meaningless. 2. Display `parallelism` in 'show export'. 3. Create an initial Map for resultAttachedInfo to avoid NullPointerException. 4. Remove the originStmt added in this PR #31020, because the `Export` statement is underlying the Outfile statement, it cannot be treated as `OriginStmt`.
Proposed changes
Issue Number: close #xxx
Forbid rollback to the old optimizer in
Exporttask. Since originStmt is empty, reverting to the old optimizer when the new optimizer is enabled is meaningless.Display
parallelismin 'show export'.Create an initial Map for resultAttachedInfo to avoid NullPointerException.
Remove the originStmt added in this PR [bugfix](export command) Export exceptions when use legacy optimizer #31020, because the
Exportstatement is underlying the Outfile statement, it cannot be treated asOriginStmt.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...