[fix](money_format) fix money_format #31883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
TeamCity be ut coverage result: |
zclllyybb
approved these changes
Mar 7, 2024
Contributor
|
PR approved by anyone and no changes requested. |
jacktengg
approved these changes
Mar 7, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Mar 7, 2024
Merged
yiguolei
pushed a commit
that referenced
this pull request
Mar 7, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 7, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 7, 2024
Closed
zhiqiang-hhhh
commented
May 9, 2024
| // truncate to 2 decimal places, keep same with mysql | ||
| double value = | ||
| MathFunctions::my_double_round(data_column->get_element(i), 2, false, false); | ||
| MathFunctions::my_double_round(data_column->get_element(i), 2, false, true); |
Contributor
Author
There was a problem hiding this comment.
should do round instead of truncate
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
now they work as mysql