Skip to content

[fix] money format #31901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 7, 2024
Merged

[fix] money format #31901

yiguolei merged 1 commit into from
Mar 7, 2024

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Mar 7, 2024

Pick #31883 to upstream branch 2.0

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Mar 7, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_string.h

#include <algorithm>
#include <array>
#include <boost/iterator/iterator_facade.hpp>
Copy link
Contributor

@github-actions github-actions bot Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'boost/iterator/iterator_facade.hpp' file not found [clang-diagnostic-error]

#include <boost/iterator/iterator_facade.hpp>
         ^

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TPC-H: Total hot run time: 50872 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b0028da50bc934fad15f86217ad96b879df22b1, data reload: false

------ Round 1 ----------------------------------
q1	18120	4492	4431	4431
q2	2022	146	139	139
q3	10464	1965	1981	1965
q4	10328	1258	1332	1258
q5	8692	4065	4017	4017
q6	230	122	126	122
q7	2055	1600	1603	1600
q8	9695	2732	2743	2732
q9	11024	11106	10904	10904
q10	11920	3655	3640	3640
q11	425	250	243	243
q12	467	299	298	298
q13	18803	3971	4129	3971
q14	355	330	338	330
q15	592	476	458	458
q16	1759	603	610	603
q17	1150	987	964	964
q18	7203	6950	6836	6836
q19	1691	1562	1567	1562
q20	521	300	307	300
q21	4430	4161	4099	4099
q22	496	407	400	400
Total cold run time: 122442 ms
Total hot run time: 50872 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4307	4325	4286	4286
q2	320	220	224	220
q3	4137	4159	4142	4142
q4	2768	2741	2746	2741
q5	7372	7214	7242	7214
q6	235	118	116	116
q7	3244	2889	2820	2820
q8	4357	4482	4483	4482
q9	17534	17084	17282	17084
q10	4232	4236	4298	4236
q11	748	663	675	663
q12	1022	856	833	833
q13	7445	3725	3721	3721
q14	447	423	431	423
q15	496	456	453	453
q16	750	695	696	695
q17	3826	3889	3949	3889
q18	8830	8834	8764	8764
q19	1742	1715	1687	1687
q20	2417	2136	2117	2117
q21	8565	8471	8575	8471
q22	1054	926	941	926
Total cold run time: 85848 ms
Total hot run time: 79983 ms

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TPC-DS: Total hot run time: 201444 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b0028da50bc934fad15f86217ad96b879df22b1, data reload: false

query1	902	393	375	375
query2	6550	2052	1877	1877
query3	6920	205	206	205
query4	20226	17937	17916	17916
query5	19712	6492	6509	6492
query6	287	216	229	216
query7	4149	308	301	301
query8	238	233	236	233
query9	3109	2745	2642	2642
query10	423	290	286	286
query11	11303	10673	10684	10673
query12	119	76	76	76
query13	5565	655	624	624
query14	17857	13292	13622	13292
query15	359	231	225	225
query16	6452	284	257	257
query17	1710	1469	858	858
query18	2327	418	407	407
query19	211	143	145	143
query20	71	76	77	76
query21	185	93	96	93
query22	5338	5109	5052	5052
query23	32530	31615	31757	31615
query24	6922	6498	6484	6484
query25	526	419	408	408
query26	527	162	158	158
query27	1797	292	288	288
query28	6141	2207	2189	2189
query29	2806	2730	2618	2618
query30	244	159	162	159
query31	909	721	721	721
query32	67	58	57	57
query33	397	238	265	238
query34	852	465	481	465
query35	1180	960	926	926
query36	1448	1626	1718	1626
query37	90	60	60	60
query38	3072	2896	2914	2896
query39	1373	1325	1327	1325
query40	196	99	83	83
query41	35	32	32	32
query42	84	88	86	86
query43	652	559	555	555
query44	1133	718	704	704
query45	235	228	227	227
query46	1362	978	984	978
query47	2036	1566	1889	1566
query48	982	711	665	665
query49	615	370	367	367
query50	870	619	642	619
query51	4709	4689	4660	4660
query52	83	82	76	76
query53	440	319	315	315
query54	2634	2488	2449	2449
query55	90	77	74	74
query56	227	212	207	207
query57	1352	1108	1059	1059
query58	214	190	204	190
query59	3526	3319	3475	3319
query60	193	201	207	201
query61	83	83	83	83
query62	878	486	449	449
query63	463	345	337	337
query64	2464	1486	1410	1410
query65	3627	3535	3552	3535
query66	754	373	368	368
query67	18018	15164	16752	15164
query68	8228	633	651	633
query69	559	341	326	326
query70	2322	1769	1739	1739
query71	386	306	313	306
query72	6410	3454	3402	3402
query73	730	326	329	326
query74	6405	5813	5782	5782
query75	4602	3735	3774	3735
query76	4689	1139	1166	1139
query77	579	241	252	241
query78	12771	11690	11927	11690
query79	7201	627	644	627
query80	1832	401	388	388
query81	510	232	226	226
query82	1509	106	98	98
query83	170	132	133	132
query84	257	69	66	66
query85	1355	285	277	277
query86	431	386	379	379
query87	3202	3032	3002	3002
query88	5082	2357	2383	2357
query89	387	279	274	274
query90	1718	207	212	207
query91	160	118	114	114
query92	55	51	54	51
query93	3315	569	585	569
query94	894	204	204	204
query95	1120	1078	1044	1044
query96	646	330	322	322
query97	6551	6521	6398	6398
query98	197	174	172	172
query99	2955	888	912	888
Total cold run time: 310077 ms
Total hot run time: 201444 ms

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

ClickBench: Total hot run time: 30.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b0028da50bc934fad15f86217ad96b879df22b1, data reload: false

query1	0.02	0.02	0.02
query2	0.05	0.03	0.02
query3	0.24	0.05	0.05
query4	1.83	0.06	0.07
query5	0.53	0.52	0.51
query6	1.25	0.61	0.61
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.54	0.48	0.49
query10	0.55	0.52	0.53
query11	0.12	0.09	0.08
query12	0.12	0.09	0.09
query13	0.63	0.61	0.61
query14	0.78	0.80	0.79
query15	0.79	0.76	0.76
query16	0.37	0.37	0.37
query17	1.00	0.98	1.00
query18	0.22	0.27	0.25
query19	1.95	1.85	1.84
query20	0.01	0.01	0.01
query21	15.48	0.57	0.58
query22	2.04	2.13	1.23
query23	17.35	1.05	0.94
query24	6.61	1.38	1.60
query25	0.40	0.11	0.05
query26	0.80	0.15	0.15
query27	0.04	0.04	0.03
query28	5.74	0.73	0.74
query29	12.60	2.38	2.31
query30	0.62	0.52	0.53
query31	2.80	0.38	0.37
query32	3.41	0.51	0.50
query33	3.10	3.08	3.10
query34	15.29	4.83	4.79
query35	4.89	4.85	4.86
query36	1.05	1.01	1.02
query37	0.05	0.05	0.04
query38	0.03	0.02	0.03
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.06	0.01	0.01
query42	0.02	0.02	0.02
query43	0.02	0.01	0.02
Total cold run time: 103.62 s
Total hot run time: 30.84 s

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 1b0028da50bc934fad15f86217ad96b879df22b1 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       20.0 seconds inserted 10000000 Rows, about 500K ops/s

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TeamCity be ut coverage result:
Function Coverage: 37.80% (8037/21263)
Line Coverage: 29.48% (65577/222421)
Region Coverage: 28.95% (33743/116569)
Branch Coverage: 24.78% (17310/69846)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1b0028da50bc934fad15f86217ad96b879df22b1_1b0028da50bc934fad15f86217ad96b879df22b1/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 6e12a00 into apache:branch-2.0 Mar 7, 2024
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_31883_to_upstream_branch-2.0 branch March 7, 2024 06:16
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zhiqiang-hhhh
[fix](money_format) fix money_format apache#31883 (apache#31901)
0889847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhiqiang-hhhh @doris-robot @yiguolei