-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refactor](nereids)unify outputTupleDesc and projection #32128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d443056
unify-join-proj
englefly 4ceb9f2
unify join
englefly 984da00
upd
Mryange 857203f
format
Mryange 6193537
vSrcToOutputSMap is empty in some cases
englefly 17970c0
add debug log
Mryange bf9db3a
format
Mryange bdc6834
fix mv
Mryange ba378c8
Merge branch 'master' of https://github.com/apache/doris into join-node
Mryange c4154ca
fix
Mryange 6f0c9bb
tmp log
Mryange c2ede1c
gix
Mryange File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function '_build_output_block' has cognitive complexity of 55 (threshold 50) [readability-function-cognitive-complexity]
Status JoinProbeLocalState<SharedStateArg, Derived>::_build_output_block( ^Additional context
be/src/pipeline/exec/join_probe_operator.cpp:89: +1, including nesting penalty of 0, nesting level increased to 1
if (!Base::_projections.empty()) { ^be/src/pipeline/exec/join_probe_operator.cpp:91: +2, including nesting penalty of 1, nesting level increased to 2
if (p._is_outer_join) { ^be/src/pipeline/exec/join_probe_operator.cpp:100: +1, including nesting penalty of 0, nesting level increased to 1
is_mem_reuse ? vectorized::MutableBlock(output_block) ^be/src/pipeline/exec/join_probe_operator.cpp:108: nesting level increased to 1
be/src/pipeline/exec/join_probe_operator.cpp:109: +2, including nesting penalty of 1, nesting level increased to 2
be/src/pipeline/exec/join_probe_operator.cpp:109: +1
be/src/pipeline/exec/join_probe_operator.cpp:110: +3, including nesting penalty of 2, nesting level increased to 3
be/src/pipeline/exec/join_probe_operator.cpp:110: +1
be/src/pipeline/exec/join_probe_operator.cpp:114: +1, nesting level increased to 3
} else { ^be/src/pipeline/exec/join_probe_operator.cpp:117: +1, nesting level increased to 2
} else { ^be/src/pipeline/exec/join_probe_operator.cpp:118: +3, including nesting penalty of 2, nesting level increased to 3
be/src/pipeline/exec/join_probe_operator.cpp:118: +1
be/src/pipeline/exec/join_probe_operator.cpp:120: +1, nesting level increased to 3
} else { ^be/src/pipeline/exec/join_probe_operator.cpp:125: +2, including nesting penalty of 1, nesting level increased to 2
be/src/pipeline/exec/join_probe_operator.cpp:128: +3, including nesting penalty of 2, nesting level increased to 3
be/src/pipeline/exec/join_probe_operator.cpp:129: +4, including nesting penalty of 3, nesting level increased to 4
if (!null_column.is_null_at(i)) { ^be/src/pipeline/exec/join_probe_operator.cpp:139: nesting level increased to 1
auto print = [](vectorized::VExprContextSPtrs& ctxs) { ^be/src/pipeline/exec/join_probe_operator.cpp:147: nesting level increased to 1
auto print_desc = [](std::unique_ptr<RowDescriptor>& desc) { ^be/src/pipeline/exec/join_probe_operator.cpp:149: +2, including nesting penalty of 1, nesting level increased to 2
if (!desc) { ^be/src/pipeline/exec/join_probe_operator.cpp:151: +1, nesting level increased to 2
} else { ^be/src/pipeline/exec/join_probe_operator.cpp:166: +1, including nesting penalty of 0, nesting level increased to 1
be/src/pipeline/exec/join_probe_operator.cpp:168: +2, including nesting penalty of 1, nesting level increased to 2
if (_output_expr_ctxs.empty()) { ^be/src/pipeline/exec/join_probe_operator.cpp:171: +3, including nesting penalty of 2, nesting level increased to 3
be/src/pipeline/exec/join_probe_operator.cpp:175: +1, nesting level increased to 2
} else { ^be/src/pipeline/exec/join_probe_operator.cpp:179: +3, including nesting penalty of 2, nesting level increased to 3
be/src/pipeline/exec/join_probe_operator.cpp:181: +4, including nesting penalty of 3, nesting level increased to 4
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \ ^be/src/pipeline/exec/join_probe_operator.cpp:181: +5, including nesting penalty of 4, nesting level increased to 5
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \ ^be/src/pipeline/exec/join_probe_operator.cpp:189: +4, including nesting penalty of 3, nesting level increased to 4
if (is_column_const(*origin_column) || ^be/src/pipeline/exec/join_probe_operator.cpp:189: +1
if (is_column_const(*origin_column) || ^be/src/pipeline/exec/join_probe_operator.cpp:193: +1, nesting level increased to 4
} else { ^