[refactor](nereids)unify outputTupleDesc and projection #32128
Conversation
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 36896 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 37252 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37018 ms |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38506 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38777 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38663 ms |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38366 ms |
|
TeamCity be ut coverage result: |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38865 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run p1 |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| template <typename SharedStateArg, typename Derived> | ||
| Status JoinProbeLocalState<SharedStateArg, Derived>::_build_output_block( |
There was a problem hiding this comment.
warning: function '_build_output_block' has cognitive complexity of 55 (threshold 50) [readability-function-cognitive-complexity]
Status JoinProbeLocalState<SharedStateArg, Derived>::_build_output_block(
^Additional context
be/src/pipeline/exec/join_probe_operator.cpp:89: +1, including nesting penalty of 0, nesting level increased to 1
if (!Base::_projections.empty()) {
^be/src/pipeline/exec/join_probe_operator.cpp:91: +2, including nesting penalty of 1, nesting level increased to 2
if (p._is_outer_join) {
^be/src/pipeline/exec/join_probe_operator.cpp:100: +1, including nesting penalty of 0, nesting level increased to 1
is_mem_reuse ? vectorized::MutableBlock(output_block)
^be/src/pipeline/exec/join_probe_operator.cpp:108: nesting level increased to 1
auto insert_column_datas = [&](auto& to, vectorized::ColumnPtr& from, size_t rows) {
^be/src/pipeline/exec/join_probe_operator.cpp:109: +2, including nesting penalty of 1, nesting level increased to 2
if (to->is_nullable() && !from->is_nullable()) {
^be/src/pipeline/exec/join_probe_operator.cpp:109: +1
if (to->is_nullable() && !from->is_nullable()) {
^be/src/pipeline/exec/join_probe_operator.cpp:110: +3, including nesting penalty of 2, nesting level increased to 3
if (keep_origin || !from->is_exclusive()) {
^be/src/pipeline/exec/join_probe_operator.cpp:110: +1
if (keep_origin || !from->is_exclusive()) {
^be/src/pipeline/exec/join_probe_operator.cpp:114: +1, nesting level increased to 3
} else {
^be/src/pipeline/exec/join_probe_operator.cpp:117: +1, nesting level increased to 2
} else {
^be/src/pipeline/exec/join_probe_operator.cpp:118: +3, including nesting penalty of 2, nesting level increased to 3
if (keep_origin || !from->is_exclusive()) {
^be/src/pipeline/exec/join_probe_operator.cpp:118: +1
if (keep_origin || !from->is_exclusive()) {
^be/src/pipeline/exec/join_probe_operator.cpp:120: +1, nesting level increased to 3
} else {
^be/src/pipeline/exec/join_probe_operator.cpp:125: +2, including nesting penalty of 1, nesting level increased to 2
if (to->is_nullable()) {
^be/src/pipeline/exec/join_probe_operator.cpp:128: +3, including nesting penalty of 2, nesting level increased to 3
for (int i = 0; i < null_column.size(); i++) {
^be/src/pipeline/exec/join_probe_operator.cpp:129: +4, including nesting penalty of 3, nesting level increased to 4
if (!null_column.is_null_at(i)) {
^be/src/pipeline/exec/join_probe_operator.cpp:139: nesting level increased to 1
auto print = [](vectorized::VExprContextSPtrs& ctxs) {
^be/src/pipeline/exec/join_probe_operator.cpp:147: nesting level increased to 1
auto print_desc = [](std::unique_ptr<RowDescriptor>& desc) {
^be/src/pipeline/exec/join_probe_operator.cpp:149: +2, including nesting penalty of 1, nesting level increased to 2
if (!desc) {
^be/src/pipeline/exec/join_probe_operator.cpp:151: +1, nesting level increased to 2
} else {
^be/src/pipeline/exec/join_probe_operator.cpp:166: +1, including nesting penalty of 0, nesting level increased to 1
if (rows != 0) {
^be/src/pipeline/exec/join_probe_operator.cpp:168: +2, including nesting penalty of 1, nesting level increased to 2
if (_output_expr_ctxs.empty()) {
^be/src/pipeline/exec/join_probe_operator.cpp:171: +3, including nesting penalty of 2, nesting level increased to 3
for (int i = 0; i < mutable_columns.size(); ++i) {
^be/src/pipeline/exec/join_probe_operator.cpp:175: +1, nesting level increased to 2
} else {
^be/src/pipeline/exec/join_probe_operator.cpp:179: +3, including nesting penalty of 2, nesting level increased to 3
for (int i = 0; i < mutable_columns.size(); ++i) {
^be/src/pipeline/exec/join_probe_operator.cpp:181: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_output_expr_ctxs[i]->execute(origin_block, &result_column_id));
^be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/join_probe_operator.cpp:181: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_output_expr_ctxs[i]->execute(origin_block, &result_column_id));
^be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/join_probe_operator.cpp:189: +4, including nesting penalty of 3, nesting level increased to 4
if (is_column_const(*origin_column) ||
^be/src/pipeline/exec/join_probe_operator.cpp:189: +1
if (is_column_const(*origin_column) ||
^be/src/pipeline/exec/join_probe_operator.cpp:193: +1, nesting level increased to 4
} else {
^
|
TeamCity be ut coverage result: |
|
run p0 |
|
run feut |
3 participants
Proposed changes
fe code : #32093
test pr #32249
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...